From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: make tools ERROR in latest xen-unstable.hg Date: Fri, 17 Jun 2011 08:01:46 +0100 Message-ID: <4DFAFBDA.8070001@eu.citrix.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Ren, Yongjie" Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 06/17/2011 07:29 AM, Ren, Yongjie wrote: > Hi all, > In our test, xen-unstable build fails. When running 'make tools', I got the following error. Do you have the same issue ? > xl_cmdimpl.c: In function 'acquire_lock': > xl_cmdimpl.c:202: error: 'O_CLOEXEC' undeclared (first use in this function) > xl_cmdimpl.c:202: error: (Each undeclared identifier is reported only once > xl_cmdimpl.c:202: error: for each function it appears in.) I've just got bitten by that in another repository [1] looks like you use an old distribution (flags that appears in the kernel in 2.6.23). The solution is simple since there's no need for the atomicity: it consists in removing O_CLOEXEC and switching to fcntl(fd, F_SETFD, FD_CLOEXEC) [1] https://github.com/xen-org/xen-api-libs/commit/523e1c5364e11e0d5bbd5308988c263392df0559 -- Vincent