From: Jens Axboe <axboe@kernel.dk>
To: Eric Gouriou <egouriou@google.com>
Cc: fio@vger.kernel.org, Nauman Rafique <nauman@google.com>,
Daniel Ehrenberg <dehrenberg@google.com>
Subject: Re: [PATCH v2] Add ability to invoke fallocate() FALLOC_FL_KEEP_SIZE.
Date: Fri, 17 Jun 2011 09:14:30 +0200 [thread overview]
Message-ID: <4DFAFED6.3070305@kernel.dk> (raw)
In-Reply-To: <1308257826-3342-1-git-send-email-egouriou@google.com>
On 2011-06-16 22:57, Eric Gouriou wrote:
> Hi Jens, all,
>
> This is version 2 of the patch submitted earlier this week. Compared
> to the initial version I removed the "fallocate_keep_size" option and,
> as suggested, changed "fallocate" to be a string option. I elected
> to provide both descriptive and numeric compatibility values for the
> old boolean values. Let me know if you disagree with that choice.
>
> I removed the weak version of fallocate(). It is not required at this
> point and not having it removed the problem of figuring what semantics
> it should have if invoked.
>
> As always, feedback is appreciated.
Thanks Eric, this looks good! Applied.
--
Jens Axboe
next prev parent reply other threads:[~2011-06-17 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 19:40 [PATCH] Add fallocate_keep_size option and functionality Eric Gouriou
2011-06-14 19:58 ` Jens Axboe
2011-06-15 1:08 ` Eric Gouriou
2011-06-16 20:57 ` [PATCH v2] Add ability to invoke fallocate() FALLOC_FL_KEEP_SIZE Eric Gouriou
2011-06-17 7:14 ` Jens Axboe [this message]
2011-06-17 19:11 ` Eric Gouriou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFAFED6.3070305@kernel.dk \
--to=axboe@kernel.dk \
--cc=dehrenberg@google.com \
--cc=egouriou@google.com \
--cc=fio@vger.kernel.org \
--cc=nauman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.