From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXTfW-0006bC-DQ for qemu-devel@nongnu.org; Fri, 17 Jun 2011 03:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QXTfU-00028v-NP for qemu-devel@nongnu.org; Fri, 17 Jun 2011 03:40:42 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:60955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QXTfU-00028m-3J for qemu-devel@nongnu.org; Fri, 17 Jun 2011 03:40:40 -0400 Message-ID: <4DFB04F4.6030200@web.de> Date: Fri, 17 Jun 2011 09:40:36 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <8199.95195274732$1308296048@news.gmane.org> In-Reply-To: <8199.95195274732$1308296048@news.gmane.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig146B1354F4BD1B9796C1A7D6" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] Fix ioapic vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk Cc: 'qemu-devel' This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig146B1354F4BD1B9796C1A7D6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-17 09:30, Pavel Dovgaluk wrote: > This patch fixes save/restore vmstate of IOAPIC. > When irr member of IOAPICState is not saved and loaded, > restoring becomes non-deterministic, because irr is kept from > state of VM that was before loading. >=20 > Signed-off-by: Pavel Dovgalyuk > --- > hw/ioapic.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >=20 > diff --git a/hw/ioapic.c b/hw/ioapic.c > index 2109568..e583284 100644 > --- a/hw/ioapic.c > +++ b/hw/ioapic.c > @@ -207,6 +207,7 @@ static const VMStateDescription vmstate_ioapic =3D = { > .fields =3D (VMStateField []) { > VMSTATE_UINT8(id, IOAPICState), > VMSTATE_UINT8(ioregsel, IOAPICState), > + VMSTATE_UINT32(irr, IOAPICState), > VMSTATE_UINT64_ARRAY(ioredtbl, IOAPICState, IOAPIC_NUM_PINS), > VMSTATE_END_OF_LIST() > } >=20 You are using an old qemu version. This was fixed via commit 35a74c5c59. Jan --------------enig146B1354F4BD1B9796C1A7D6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk37BPQACgkQitSsb3rl5xSDZgCgjNBeXzroYjV7j8nZmfWM6FSR AI4AoKDmIaZZzApvKrDZCEQX9GYJuEk2 =1QYd -----END PGP SIGNATURE----- --------------enig146B1354F4BD1B9796C1A7D6--