[Question] ehci_hcd: inclusion of multiple platform drivers

[Question] ehci_hcd: inclusion of multiple platform drivers

[mgautam]

Hi,

I am working on an SOC where requirement is to include more than one host
controller platform driver from ehci_hcd.c.
Since, the current framework supports inclusion of just one platform
driver,  I was wondering if we can have some generic solution similar to
below in ehci_hcd.c:

#ifdef CONFIG_USB_EHCI_FSL
#include "ehci-fsl.c"
#endif

#ifdef CONFIG_USB_EHCI_MXC
#include "ehci-mxc.c"
#endif

<...snip....>

static struct platform_driver *plat_drivers[]  = { #ifdef
CONFIG_USB_EHCI_FSL &ehci_fsl_driver, #endif

#ifdef CONFIG_USB_EHCI_MXC
&ehci_mxc_driver,
#endif

.....
}

And we can register all the drivers entries in a for loop from ehci_hcd_init.

Kindly let me know if this approach looks fine. I shall then submit a patch.
I am sorry for not placing the actual patch in this mail for review.


Thanks,
Manu

Re: [Question] ehci_hcd: inclusion of multiple platform drivers

[Anirudh Ghayal]

Including linux-usb.

On 6/17/2011 6:18 PM, mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote:
> Hi,
>
> I am working on an SOC where requirement is to include more than one host
> controller platform driver from ehci_hcd.c.
> Since, the current framework supports inclusion of just one platform
> driver,  I was wondering if we can have some generic solution similar to
> below in ehci_hcd.c:
>
> #ifdef CONFIG_USB_EHCI_FSL
> #include "ehci-fsl.c"
> #endif
>
> #ifdef CONFIG_USB_EHCI_MXC
> #include "ehci-mxc.c"
> #endif
>
> <...snip....>
>
> static struct platform_driver *plat_drivers[]  = { #ifdef
> CONFIG_USB_EHCI_FSL&ehci_fsl_driver, #endif
>
> #ifdef CONFIG_USB_EHCI_MXC
> &ehci_mxc_driver,
> #endif
>
> .....
> }
>
> And we can register all the drivers entries in a for loop from ehci_hcd_init.
>
> Kindly let me know if this approach looks fine. I shall then submit a patch.
> I am sorry for not placing the actual patch in this mail for review.
>
>
> Thanks,
> Manu
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [Question] ehci_hcd: inclusion of multiple platform drivers

[Sebastian Andrzej Siewior]

* Anirudh Ghayal | 2011-06-17 18:26:24 [+0530]:

>Including linux-usb.
>
>On 6/17/2011 6:18 PM, mgautam@codeaurora.org wrote:
>>Hi,
>>
>>I am working on an SOC where requirement is to include more than one host
>>controller platform driver from ehci_hcd.c.
>>Since, the current framework supports inclusion of just one platform
>>driver,  I was wondering if we can have some generic solution similar to
>>below in ehci_hcd.c:

Take a look at the "usb: host: xhci: give xhci a platform_device" thread
where Felipe suggest a platform device for xhci [0]. Maybe something
similar should be done [eou]hci as well. Simply add one device with
proper ressources.

[0] http://article.gmane.org/gmane.linux.usb.general/48028

Sebastian