All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] lvm2: add configuration option to enable udev fallback code only when needed
Date: Fri, 17 Jun 2011 15:59:32 +0200	[thread overview]
Message-ID: <4DFB5DC4.3070908@redhat.com> (raw)
In-Reply-To: <4DFB4B09.9080902@redhat.com>

On 06/17/2011 02:39 PM, Peter Rajnoha wrote:
> We've used udev fallback code till now to check whether udev
> created/removed the entries in /dev correctly and if not,
> a repair was done (giving a warning messagea about that).
> 
> This patch adds a possibility to enable this additional check
> and subsequent fallback only when required (debugging purposes
> mostly) and trust udev completely.
> 
> So let's disable the fallback code by default and add a new
> configuration option "activation/udev_fallback".

ack.

(also systemd people should be happy, because fallback hides
problems in dependencies.)

> @@ -36,6 +36,7 @@ struct config_info {
>  	int read_ahead;		/* DM_READ_AHEAD_NONE or _AUTO */
>  	int udev_rules;
>  	int udev_sync;
> +	int udev_fallback;

nitpicking - isn't it wasting of space? udev_fallback:1 ? ;-)
(probably some patch later if it is worth to do that)

Milan



      reply	other threads:[~2011-06-17 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17 12:39 [PATCH] lvm2: add configuration option to enable udev fallback code only when needed Peter Rajnoha
2011-06-17 13:59 ` Milan Broz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFB5DC4.3070908@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.