From: Eric Sandeen <sandeen@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
mitchb@mit.edu, Bruce Cassidy <bruce@whamcloud.com>
Subject: Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir
Date: Fri, 17 Jun 2011 09:27:07 -0500 [thread overview]
Message-ID: <4DFB643B.3020600@redhat.com> (raw)
In-Reply-To: <20110617023149.GD29725@thunk.org>
On 6/16/11 9:31 PM, Ted Ts'o wrote:
> On Thu, Jun 16, 2011 at 03:39:07PM -0500, Eric Sandeen wrote:
>>> Hm, now in a "make rpm" build which has source in one place and rpm build
>>> area in another:
>>>
>>> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
>>>
>>> so I'm not quite sure how to work around this.
>>>
>>> Maybe in the end it does have to be packaging-specific, with the
>>> link created by the distro pkg scripts...?
>>
>> Ted, your change broke any builds span 2 different filesystems.
>
> I thought I fixed this with commit 1e082c62?
Oh, maybe you did; I didn't see any reply to my original problem report,
and I didn't see the patch sent to the list (maybe I missed it?)
So I assumed it wasn't yet fixed, TBH I don't usually build cross-fs
that way so hadn't actually retested, sorry. Seems like it should
be fine now, thanks.
As for Andreas' comment:
> I had to return the "-s" back as well, but the current code looks OK.
> The chance of separate filesystems for /usr/include and /usr/include/et
> being used seems vanishingly small.
my problem was actually during the RPM packaging, so a slightly different
situation.
-Eric
> Which Makefile is breaking? Is this the one in lib/et/Makefile.in?
> It currently reads:
>
> $(Q) (cd $(DESTDIR)$(includedir) ;\
> $(LN) $(LINK_INSTALL_FLAGS) et/com_err.h . )
>
> and I don't see how that could have generated the error you've cited
> above...
>
> - Ted
>
>
prev parent reply other threads:[~2011-06-17 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 18:01 [PATCH] e2fsprogs: create com_err.h symlink in includedir Eric Sandeen
2011-02-20 23:10 ` Ted Ts'o
2011-03-19 15:03 ` Eric Sandeen
2011-06-16 20:39 ` Eric Sandeen
2011-06-17 2:31 ` Ted Ts'o
2011-06-17 3:54 ` Andreas Dilger
2011-06-17 14:27 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFB643B.3020600@redhat.com \
--to=sandeen@redhat.com \
--cc=bruce@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mitchb@mit.edu \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.