All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] Fix hang when entering udelay after GPTIMER2 overflows (about 22 minutes on AM37x)
Date: Fri, 17 Jun 2011 18:40:17 +0300	[thread overview]
Message-ID: <4DFB7561.4090500@compulab.co.il> (raw)
In-Reply-To: <E1QXIcV-0001NZ-I5@amazonia.comcast.net>

Hi Rick,

I've been browsing through the mailing list and found a similar patch [1]
sent about a half a year ago by: John Rigby <john.rigby@linaro.org>
It has neither been accepted, nor rejected.

It looks like John's patch is a bit cleaner and has a more complete
commit message. I can test it on DM3730/AM3703/OMAP3530
and some time later on AM3517.
Can you please, also test it on your available hardware?

Sandeep,
can you please, take a look at this?

[1] http://patchwork.ozlabs.org/patch/76803/


On 06/16/11 22:52, Rick Bronson wrote:
> Hi Igor,
>
>   Yes, I have tested this on the AM3715 but not on any other parts.
>
>   Cheers,
>
>   Rick
>
>> On 05/17/11 00:52, rick at efn.org wrote:
>>
>>> Signed-off-by: Rick Bronson <rick@efn.org>
>>> ---
>>>  arch/arm/cpu/armv7/omap-common/timer.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/cpu/armv7/omap-common/timer.c
>>> b/arch/arm/cpu/armv7/omap-common/timer.c
>>> index 9beebb1..3c9d488 100644
>>> --- a/arch/arm/cpu/armv7/omap-common/timer.c
>>> +++ b/arch/arm/cpu/armv7/omap-common/timer.c
>>> @@ -44,7 +44,7 @@ static struct gptimer *timer_base = (struct gptimer
>>> *)CONFIG_SYS_TIMERBASE;
>>>   */
>>>
>>>  #define TIMER_CLOCK	(V_SCLK / (2 << CONFIG_SYS_PTV))
>>> -#define TIMER_LOAD_VAL	0xffffffff
>>> +#define TIMER_LOAD_VAL	0  /* counter starts from 0 on reload */
>> Has this been tested?
>> If yes, then on what hardware (board)?
>> Is it only AM SoCs or DM too?
>>
>>
>> -- 
>> Regards,
>> Igor.
>>
>>
>>

-- 
Regards,
Igor.

  reply	other threads:[~2011-06-17 15:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 21:52 [U-Boot] [PATCH 1/1] Fix hang when entering udelay after GPTIMER2 overflows (about 22 minutes on AM37x) rick at efn.org
2011-06-16 16:43 ` Igor Grinberg
2011-06-16 19:52   ` Rick Bronson
2011-06-17 15:40     ` Igor Grinberg [this message]
2011-06-17 16:34       ` Rick Bronson
  -- strict thread matches above, loose matches on Subject: below --
2011-05-15 18:19 rick at efn.org
2011-05-06  5:10 rick at efn.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFB7561.4090500@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.