All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasileios Karakasis <bkk@cslab.ece.ntua.gr>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-numa@vger.kernel.org
Subject: Re: [BUG] Invalid return address of mmap() followed by mbind() in multithreaded context
Date: Sat, 18 Jun 2011 21:41:03 +0300	[thread overview]
Message-ID: <4DFCF13F.50401@cslab.ece.ntua.gr> (raw)
In-Reply-To: <20110618181232.GI16236@one.firstfloor.org>

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

That's right, but what I want to demonstrate is that the address
returned by mmap() is invalid and the dereference crashes the program,
while it shouldn't. I could equally omit this statement, in which case
mbind() would fail with EFAULT.

On 06/18/2011 09:12 PM, Andi Kleen wrote:
>>     for (i = 0; i < NR_ITER; i++) {
>>         addr = mmap(0, PAGE_SIZE, PROT_READ | PROT_WRITE,
>>                     MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
>>         if (addr == (void *) -1) {
>>             assert(0 && "mmap failed");
>>         }
>>         *addr = 0;
>>
>>         err = mbind(addr, PAGE_SIZE, MPOL_BIND, &node, sizeof(node), 0);
> 
> mbind() can be only done before the first touch. you're not actually testing 
> numa policy.
> 
> -andi

-- 
V.K.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2011-06-18 18:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17 15:21 [BUG] Invalid return address of mmap() followed by mbind() in multithreaded context Vasileios Karakasis
2011-06-18 18:12 ` Andi Kleen
2011-06-18 18:12   ` Andi Kleen
2011-06-18 18:41   ` Vasileios Karakasis [this message]
2011-06-19 23:42     ` Vasileios Karakasis
2011-06-27 17:18 ` Kornilios Kourtis
2011-06-27 17:18   ` Kornilios Kourtis
2011-06-28  2:06   ` KOSAKI Motohiro
2011-06-28  2:06     ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFCF13F.50401@cslab.ece.ntua.gr \
    --to=bkk@cslab.ece.ntua.gr \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-numa@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.