From: Avi Kivity <avi@redhat.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Optimize screendump
Date: Sun, 19 Jun 2011 19:04:13 +0300 [thread overview]
Message-ID: <4DFE1DFD.2040902@redhat.com> (raw)
In-Reply-To: <E1B347AD-243D-4BE0-9038-A875A93EEEF7@web.de>
On 06/19/2011 06:53 PM, Andreas Färber wrote:
> Am 19.06.2011 um 17:46 schrieb Avi Kivity:
>
>> On 06/19/2011 06:22 PM, Stefan Hajnoczi wrote:
>>> I wonder if this will break non-Linux platforms. Perhaps buffer an
>>> entire row of pixels instead and only fwrite(3) at the end of the
>>> outer loop.
>>
>> That's how I wrote this in the first place. Since the consensus is
>> against these functions, I'll submit that version instead.
>
> Maybe add a qemu_fputc_unlocked() and do a configure check for it?
Good idea. I'll try that, unless people disagree.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-06-19 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 14:54 [Qemu-devel] [PATCH] Optimize screendump Avi Kivity
2011-06-19 15:05 ` malc
2011-06-19 15:22 ` Stefan Hajnoczi
2011-06-19 15:46 ` Avi Kivity
2011-06-19 15:53 ` Andreas Färber
2011-06-19 16:04 ` Avi Kivity [this message]
2011-06-19 17:00 ` Alexander Graf
2011-06-20 8:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFE1DFD.2040902@redhat.com \
--to=avi@redhat.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.