From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: [PATCH v2 1/5] net: Support ethtool ops for rx of errored frames. Date: Sun, 19 Jun 2011 16:15:56 -0700 Message-ID: <4DFE832C.7000100@candelatech.com> References: <1308430045-24816-1-git-send-email-greearb@candelatech.com> <1308430045-24816-2-git-send-email-greearb@candelatech.com> <20110618213400.GA2741@electric-eye.fr.zoreil.com> <4DFE57DA.8090404@candelatech.com> <20110619224800.GA2861@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Francois Romieu Return-path: Received: from mail.candelatech.com ([208.74.158.172]:52265 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754170Ab1FSXP7 (ORCPT ); Sun, 19 Jun 2011 19:15:59 -0400 In-Reply-To: <20110619224800.GA2861@electric-eye.fr.zoreil.com> Sender: netdev-owner@vger.kernel.org List-ID: On 06/19/2011 03:48 PM, Francois Romieu wrote: > Ben Greear : >> On 06/18/2011 02:34 PM, Francois Romieu wrote: >>> greearb@candelatech.com : >>> [...] >>>> This can be useful when sniffing dodgy networks. >>> >>> Do you plan to add something similar - i.e. not per packet - for the Tx path ? >> >> Ability to tx errored frames? I posted a patch to enable sending >> frames with custom (ie, invalid) Ethernet FCS, but you have to >> enable it per-socket, and it will only work with AF_PACKET sockets. >> >> Can you offer more details on what you are asking for? > > Realtek's 816[89] and 810[23] have no room in their Tx descriptors to > control ethernet checksum generation. There is a global register (TxConfig) > though. Before looking at the per-socket information, the driver would need > to be instructed to disable Tx hardware ethernet checksumming globally. Ok. I think I'll take a stab at adding a more general low-level-flags API to ethtool, with a bitfield that can be used to twiddle these sorts of things. That way, we won't have to add new methods every time we poke a new feature in. This would be separate from the 'features' patches that are floating around. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com