From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p5K0isUB094934 for ; Sun, 19 Jun 2011 19:44:55 -0500 Received: from fgwmail6.fujitsu.co.jp (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 22A4351EBE0 for ; Sun, 19 Jun 2011 17:44:51 -0700 (PDT) Received: from fgwmail6.fujitsu.co.jp (fgwmail6.fujitsu.co.jp [192.51.44.36]) by cuda.sgi.com with ESMTP id rNfPiDsSKLRWvv9B for ; Sun, 19 Jun 2011 17:44:51 -0700 (PDT) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 3B60A3EE0B5 for ; Mon, 20 Jun 2011 09:44:44 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 1D0E045DE72 for ; Mon, 20 Jun 2011 09:44:44 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 0044E45DE6A for ; Mon, 20 Jun 2011 09:44:44 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id CC966E08001 for ; Mon, 20 Jun 2011 09:44:43 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.240.81.133]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 3CA9DE08003 for ; Mon, 20 Jun 2011 09:44:43 +0900 (JST) Message-ID: <4DFE97F1.2030206@jp.fujitsu.com> Date: Mon, 20 Jun 2011 09:44:33 +0900 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> In-Reply-To: <1306998067-27659-2-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: david@fromorbit.com Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com KDIwMTEvMDYvMDIgMTY6MDApLCBEYXZlIENoaW5uZXIgd3JvdGU6Cj4gRnJvbTogRGF2ZSBDaGlu bmVyIDxkY2hpbm5lckByZWRoYXQuY29tPgo+IAo+INCGdCBpcyBpbXBvc3NpYmxlIHRvIHVuZGVy c3RhbmQgd2hhdCB0aGUgc2hyaW5rZXJzIGFyZSBhY3R1YWxseSBkb2luZwo+IHdpdGhvdXQgaW5z dHJ1bWVudGluZyB0aGUgY29kZSwgc28gYWRkIGEgc29tZSB0cmFjZXBvaW50cyB0byBhbGxvdwo+ IGluc2lnaHQgdG8gYmUgZ2FpbmVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhdmUgQ2hpbm5lciA8 ZGNoaW5uZXJAcmVkaGF0LmNvbT4KPiAtLS0KPiAgaW5jbHVkZS90cmFjZS9ldmVudHMvdm1zY2Fu LmggfCAgIDY3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIG1t L3Ztc2Nhbi5jICAgICAgICAgICAgICAgICAgIHwgICAgNiArKystCj4gIDIgZmlsZXMgY2hhbmdl ZCwgNzIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKClRoaXMgbG9vayBnb29kIHRvIG1l LiBJIGhhdmUgdHdvIG1pbm9yIHJlcXVlc3QuIDEpIHBsZWFzZSBjaGFuZ2UgcGF0Y2ggb3JkZXIs Cm1vdmUgdGhpcyBwYXRjaCBhZnRlciBzaHJpbmtlciBjaGFuZ2VzLiBpb3csIG5vdyBib3RoIHRo aXMgYW5kIFsyLzEyXSBoYXZlCnRyYWNlcG9pbnQgY2hhbmdlLiBJIGRvbid0IGxpa2UgaXQuIDIp IHBsZWFzZSBhdm9pZCBjcnlwdGljIGFiYnJldmlhdGVkIHZhcmlhYmxlCm5hbWVzLiBJbnN0ZWFk LCBwbGVhc2UganVzdCB1c2UgdGhlIHNhbWUgdmFyaWFibGUgbmFtZSB3aXRoIHZtc2Nhbi5jIHNv dXJjZSBjb2RlLgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCnhmcyBtYWlsaW5nIGxpc3QKeGZzQG9zcy5zZ2kuY29tCmh0dHA6Ly9vc3Muc2dpLmNvbS9t YWlsbWFuL2xpc3RpbmZvL3hmcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751502Ab1FTAov (ORCPT ); Sun, 19 Jun 2011 20:44:51 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:58028 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756Ab1FTAot (ORCPT ); Sun, 19 Jun 2011 20:44:49 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4DFE97F1.2030206@jp.fujitsu.com> Date: Mon, 20 Jun 2011 09:44:33 +0900 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: david@fromorbit.com CC: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> In-Reply-To: <1306998067-27659-2-git-send-email-david@fromorbit.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2011/06/02 16:00), Dave Chinner wrote: > From: Dave Chinner > > Іt is impossible to understand what the shrinkers are actually doing > without instrumenting the code, so add a some tracepoints to allow > insight to be gained. > > Signed-off-by: Dave Chinner > --- > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++++++++++ > mm/vmscan.c | 6 +++- > 2 files changed, 72 insertions(+), 1 deletions(-) This look good to me. I have two minor request. 1) please change patch order, move this patch after shrinker changes. iow, now both this and [2/12] have tracepoint change. I don't like it. 2) please avoid cryptic abbreviated variable names. Instead, please just use the same variable name with vmscan.c source code. From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints Date: Mon, 20 Jun 2011 09:44:33 +0900 Message-ID: <4DFE97F1.2030206@jp.fujitsu.com> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com To: david@fromorbit.com Return-path: In-Reply-To: <1306998067-27659-2-git-send-email-david@fromorbit.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org (2011/06/02 16:00), Dave Chinner wrote: > From: Dave Chinner >=20 > =D0=86t is impossible to understand what the shrinkers are actually doi= ng > without instrumenting the code, so add a some tracepoints to allow > insight to be gained. >=20 > Signed-off-by: Dave Chinner > --- > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++= ++++++++ > mm/vmscan.c | 6 +++- > 2 files changed, 72 insertions(+), 1 deletions(-) This look good to me. I have two minor request. 1) please change patch or= der, move this patch after shrinker changes. iow, now both this and [2/12] hav= e tracepoint change. I don't like it. 2) please avoid cryptic abbreviated v= ariable names. Instead, please just use the same variable name with vmscan.c sour= ce code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter= .ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 6D2B96B0012 for ; Sun, 19 Jun 2011 20:44:52 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id BAA133EE0CF for ; Mon, 20 Jun 2011 09:44:46 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 9763D45DE67 for ; Mon, 20 Jun 2011 09:44:43 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 7F5FF45DE8E for ; Mon, 20 Jun 2011 09:44:43 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 71F591DB803F for ; Mon, 20 Jun 2011 09:44:43 +0900 (JST) Received: from ml13.s.css.fujitsu.com (ml13.s.css.fujitsu.com [10.240.81.133]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 3ACB31DB803E for ; Mon, 20 Jun 2011 09:44:43 +0900 (JST) Message-ID: <4DFE97F1.2030206@jp.fujitsu.com> Date: Mon, 20 Jun 2011 09:44:33 +0900 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> In-Reply-To: <1306998067-27659-2-git-send-email-david@fromorbit.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: david@fromorbit.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com (2011/06/02 16:00), Dave Chinner wrote: > From: Dave Chinner > > D?t is impossible to understand what the shrinkers are actually doing > without instrumenting the code, so add a some tracepoints to allow > insight to be gained. > > Signed-off-by: Dave Chinner > --- > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++++++++++ > mm/vmscan.c | 6 +++- > 2 files changed, 72 insertions(+), 1 deletions(-) This look good to me. I have two minor request. 1) please change patch order, move this patch after shrinker changes. iow, now both this and [2/12] have tracepoint change. I don't like it. 2) please avoid cryptic abbreviated variable names. Instead, please just use the same variable name with vmscan.c source code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org