From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p5K4Ud4M114161 for ; Sun, 19 Jun 2011 23:30:41 -0500 Received: from fgwmail6.fujitsu.co.jp (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2CA18166C0F1 for ; Sun, 19 Jun 2011 21:30:38 -0700 (PDT) Received: from fgwmail6.fujitsu.co.jp (fgwmail6.fujitsu.co.jp [192.51.44.36]) by cuda.sgi.com with ESMTP id BOjGaryYEwuk8bfV for ; Sun, 19 Jun 2011 21:30:38 -0700 (PDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id BEB0C3EE0C0 for ; Mon, 20 Jun 2011 13:30:36 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 6FCD845DE8D for ; Mon, 20 Jun 2011 13:30:36 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 593A045DE67 for ; Mon, 20 Jun 2011 13:30:36 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 4D6371DB8037 for ; Mon, 20 Jun 2011 13:30:36 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.240.81.146]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id D62161DB8038 for ; Mon, 20 Jun 2011 13:30:35 +0900 (JST) Message-ID: <4DFECCE5.5030409@jp.fujitsu.com> Date: Mon, 20 Jun 2011 13:30:29 +0900 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-3-git-send-email-david@fromorbit.com> <4DFE987E.1070900@jp.fujitsu.com> <20110620012531.GN561@dastard> In-Reply-To: <20110620012531.GN561@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: david@fromorbit.com Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com >> Looks great fix. Please remove tracepoint change from this patch and send it >> to -stable. iow, I expect I'll ack your next spin. > > I don't believe such a change belongs in -stable. This code has been > buggy for many years and as I mentioned it actually makes existing > bad shrinker behaviour worse. I don't test stable kernels, so I've > got no idea what side effects it will have outside of this series. > I'm extremely hesitant to change VM behaviour in stable kernels > without having tested first, so I'm not going to push it for stable > kernels. Ok, I have no strong opinion. > > If you want it in stable kernels, then you can always let > stable@kernel.org know once the commits are in the mainline tree and > you've tested them... _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751718Ab1FTEaj (ORCPT ); Mon, 20 Jun 2011 00:30:39 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:35940 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139Ab1FTEai (ORCPT ); Mon, 20 Jun 2011 00:30:38 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 Message-ID: <4DFECCE5.5030409@jp.fujitsu.com> Date: Mon, 20 Jun 2011 13:30:29 +0900 From: KOSAKI Motohiro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: david@fromorbit.com CC: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com Subject: Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-3-git-send-email-david@fromorbit.com> <4DFE987E.1070900@jp.fujitsu.com> <20110620012531.GN561@dastard> In-Reply-To: <20110620012531.GN561@dastard> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Looks great fix. Please remove tracepoint change from this patch and send it >> to -stable. iow, I expect I'll ack your next spin. > > I don't believe such a change belongs in -stable. This code has been > buggy for many years and as I mentioned it actually makes existing > bad shrinker behaviour worse. I don't test stable kernels, so I've > got no idea what side effects it will have outside of this series. > I'm extremely hesitant to change VM behaviour in stable kernels > without having tested first, so I'm not going to push it for stable > kernels. Ok, I have no strong opinion. > > If you want it in stable kernels, then you can always let > stable@kernel.org know once the commits are in the mainline tree and > you've tested them... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 152A46B0012 for ; Mon, 20 Jun 2011 00:30:43 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 322733EE0B6 for ; Mon, 20 Jun 2011 13:30:36 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 147F445DE68 for ; Mon, 20 Jun 2011 13:30:36 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id EFE4745DE4D for ; Mon, 20 Jun 2011 13:30:35 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id E41291DB8038 for ; Mon, 20 Jun 2011 13:30:35 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.240.81.146]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id AEBE21DB802C for ; Mon, 20 Jun 2011 13:30:35 +0900 (JST) Message-ID: <4DFECCE5.5030409@jp.fujitsu.com> Date: Mon, 20 Jun 2011 13:30:29 +0900 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-3-git-send-email-david@fromorbit.com> <4DFE987E.1070900@jp.fujitsu.com> <20110620012531.GN561@dastard> In-Reply-To: <20110620012531.GN561@dastard> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: david@fromorbit.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com >> Looks great fix. Please remove tracepoint change from this patch and send it >> to -stable. iow, I expect I'll ack your next spin. > > I don't believe such a change belongs in -stable. This code has been > buggy for many years and as I mentioned it actually makes existing > bad shrinker behaviour worse. I don't test stable kernels, so I've > got no idea what side effects it will have outside of this series. > I'm extremely hesitant to change VM behaviour in stable kernels > without having tested first, so I'm not going to push it for stable > kernels. Ok, I have no strong opinion. > > If you want it in stable kernels, then you can always let > stable@kernel.org know once the commits are in the mainline tree and > you've tested them... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org