All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Hefty,
	Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Mike Marciniszyn
	<mike.marciniszyn-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org>
Subject: Re: IBoE updates - GID change event / network flow counters (was: [PATCH 7/9] ib/pma: add include file for IBA perf counters)
Date: Mon, 20 Jun 2011 19:46:54 +0300	[thread overview]
Message-ID: <4DFF797E.5090904@mellanox.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A8237302184A-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>

Hefty, Sean wrote:
> at this point, you're patches look good to me and are an improvement over what's there now.  
> So, I'd file this comment as a future nice to have.

Roland,

My patch series went through Sean's review (and passed... patch 7/9 
needed fixes and I posted V1 for it) any more feedback you need to 
accept them or you just want to go over them yourself?

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-06-20 16:46 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 14:38 [PATCH 0/9] IBoE updates: GID change event and network flow counters Or Gerlitz
     [not found] ` <alpine.LRH.2.00.1106151733410.15844-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-06-15 14:39   ` [PATCH 1/9] ib/core: Add GID change event Or Gerlitz
2011-06-15 14:40   ` [PATCH 2/9] ib/mlx4: use GID change event on IBoE code Or Gerlitz
2011-06-15 14:41   ` [PATCH 3/9] mlx4: extend cap flags to 64 bit Or Gerlitz
2011-06-15 14:42   ` [PATCH 4/9] mlx4: align current extended capabilities to use the flags field Or Gerlitz
     [not found]     ` <alpine.LRH.2.00.1106151742330.15844-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-07-07 19:19       ` [PATCH V1 " Or Gerlitz
2011-06-15 14:43   ` [PATCH 5/NNN] mlx4: Fix layout of QP context for correct location of counter index Or Gerlitz
2011-06-15 14:47   ` [PATCH 6/9] mlx4: add network flow counters Or Gerlitz
     [not found]     ` <alpine.LRH.2.00.1106151745060.15844-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-06-15 15:22       ` Hefty, Sean
2011-06-15 14:48   ` [PATCH 7/9] ib/pma: add include file for IBA performance counters definitions Or Gerlitz
     [not found]     ` <alpine.LRH.2.00.1106151747390.15844-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-06-15 16:08       ` Hal Rosenstock
     [not found]         ` <4DF8D90A.1000208-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-06-16  8:01           ` Or Gerlitz
2011-06-15 23:10       ` Hefty, Sean
     [not found]         ` <1828884A29C6694DAF28B7E6B8A8237302148F-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-06-15 23:46           ` Ira Weiny
     [not found]             ` <20110615164619.994a49a4.weiny2-i2BcT+NCU+M@public.gmane.org>
2011-06-15 23:51               ` Hefty, Sean
2011-06-16  7:39           ` Or Gerlitz
     [not found]             ` <4DF9B319.6070100-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-06-16 16:19               ` Hefty, Sean
     [not found]                 ` <1828884A29C6694DAF28B7E6B8A8237302184A-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2011-06-16 17:57                   ` Or Gerlitz
2011-06-20 16:46                   ` Or Gerlitz [this message]
     [not found]                     ` <4DFF797E.5090904-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-06-20 18:18                       ` IBoE updates - GID change event / network flow counters (was: [PATCH 7/9] ib/pma: add include file for IBA perf counters) Roland Dreier
     [not found]                         ` <BANLkTi=VR6v=xSwzLRHDL1x2=05wF-H5KQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-20 20:38                           ` Or Gerlitz
2011-07-16 19:57                           ` Or Gerlitz
2011-06-16  8:20       ` [PATCH V1 7/9] ib/pma: add include file for IBA performance counters definitions Or Gerlitz
     [not found]         ` <alpine.LRH.2.00.1106161119120.12552-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2011-06-16 14:18           ` Or Gerlitz
     [not found]             ` <4DFA10CC.5080002-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-06-16 15:49               ` Mike Marciniszyn
     [not found]                 ` <35AAF1E4A771E142979F27B51793A4888838E71F03-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2011-06-16 18:14                   ` Or Gerlitz
     [not found]                     ` <BANLkTikpMWYaXB8Ne+FaLGHi2L5TUCNDkQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-05 15:49                       ` Mike Marciniszyn
     [not found]                         ` <35AAF1E4A771E142979F27B51793A4888838FEE740-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2011-07-05 16:01                           ` Or Gerlitz
     [not found]                             ` <4E133575.8040105-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-07-05 19:34                               ` Roland Dreier
     [not found]                                 ` <CAL1RGDX7U=PMjWadeS3Gp+xST56xJiK=qydwu1PMcvkfb7DcnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-06  3:11                                   ` Or Gerlitz
     [not found]                                     ` <CAJZOPZK3tT9gXP46ek-tO3xyvj7=eKyGJXBoim9uOMbJc4BtfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-06 12:39                                       ` Mike Marciniszyn
     [not found]                                         ` <35AAF1E4A771E142979F27B51793A4888838FEE894-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org>
2011-07-06 15:51                                           ` Roland Dreier
     [not found]                                             ` <CAL1RGDWHYMQHbZWwkysqZ7TLrB_ZDJWSTC4YCqk1wpme_3+BrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-06 16:57                                               ` Hal Rosenstock
     [not found]                                                 ` <4E14940A.9080700-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-07-06 17:50                                                   ` Roland Dreier
     [not found]                                                     ` <CAL1RGDVpuwsgfVRxNw098W_wRECGn0uinQR+8txE96n5KtDXgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-07-06 18:15                                                       ` Jason Gunthorpe
     [not found]                                                         ` <20110706181507.GC1162-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-07-06 18:24                                                           ` Hal Rosenstock
     [not found]                                                             ` <4E14A87B.2070405-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2011-07-06 18:45                                                               ` Jason Gunthorpe
     [not found]                                                                 ` <20110706184511.GD1162-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-07-06 18:53                                                                   ` Hal Rosenstock
2011-07-06 18:27                                                       ` Hal Rosenstock
2011-07-07  6:55                                                       ` Or Gerlitz
2011-07-06 16:47                                           ` Ira Weiny
2011-07-05 15:46           ` [PATCH V2 " Or Gerlitz
2011-06-15 14:49   ` [PATCH 8/9] ib/mlx4: use flow counters on IBoE ports Or Gerlitz
2011-06-15 14:51   ` [PATCH 9/9] ib/mlx4: support PMA counters for IBoE Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFF797E.5090904@mellanox.com \
    --to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mike.marciniszyn-h88ZbnxC6KDQT0dZR+AlfA@public.gmane.org \
    --cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.