From: Brian King <brking@linux.vnet.ibm.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-scsi@vger.kernel.org,
Fujita Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH 2/2] [SCSI] ibmvscsi: Fix SCSI scanning
Date: Mon, 20 Jun 2011 14:06:57 -0500 [thread overview]
Message-ID: <4DFF9A51.1010400@linux.vnet.ibm.com> (raw)
In-Reply-To: <201106191348.40759.bvanassche@acm.org>
On 06/19/2011 06:48 AM, Bart Van Assche wrote:
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 3d391dc..c31adf5 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -498,6 +498,11 @@ static void purge_requests(struct ibmvscsi_host_data *hostdata, int error_code)
> spin_unlock_irqrestore(hostdata->host->host_lock, flags);
> }
>
> +static int ibmvscsi_target_alloc(struct scsi_target *starget)
> +{
> + return starget->channel == 0 ? 0 : -ENODEV;
> +}
> +
This will break existing IBM Power users who have more than 64 virtual disks assigned
to a single virtual scsi adapter. The IBM VSCSI target uses Logical Unit Addressing (10b)
and does bus/id/lun -> vscsi LUN mapping as defined in SAM. The 65'th virtual scsi
disk would show up on bus 1 as target 0.
Thanks,
Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
prev parent reply other threads:[~2011-06-20 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-19 11:48 [PATCH 2/2] [SCSI] ibmvscsi: Fix SCSI scanning Bart Van Assche
2011-06-20 11:40 ` Christoph Hellwig
2011-06-20 17:58 ` Bart Van Assche
2011-06-20 19:10 ` Brian King
2011-06-20 19:06 ` Brian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF9A51.1010400@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=bvanassche@acm.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.