From: Jens Axboe <jaxboe@fusionio.com>
To: Justin TerAvest <teravest@google.com>
Cc: "vgoyal@redhat.com" <vgoyal@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>
Subject: Re: [PATCH] cfq: Remove special treatment for metadata rqs.
Date: Mon, 20 Jun 2011 22:05:40 +0200 [thread overview]
Message-ID: <4DFFA814.40006@fusionio.com> (raw)
In-Reply-To: <BANLkTin6yt5PCG1uOamGiGjU++tznQNkAcdTGfNDOhLQvU-1=g@mail.gmail.com>
On 2011-06-20 22:03, Justin TerAvest wrote:
> On Mon, Jun 20, 2011 at 12:59 PM, Jens Axboe <jaxboe@fusionio.com> wrote:
>> On 2011-06-20 21:52, Justin TerAvest wrote:
>>> There is no consistency among filesystems from what bios (or requests)
>>> are marked as being metadata. It's interesting to expose this in traces,
>>> but we shouldn't schedule the requests differently based on whether or
>>> not they're marked as being metadata.
>>
>> Agree, we should kill that. What is this patch against? cfq_choose_req()
>> also has a "choose meta over non-meta" preference.
>
> This is against for-3.1. Let me know if you want it against something else.
Great, right branch.
> Sorry, I missed the preference in cfq_choose_req, since it changed to
> be clever about bit operations. I'll send a v2 patch that cleans that
> use up as well.
Thanks!
--
Jens Axboe
prev parent reply other threads:[~2011-06-20 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 19:52 [PATCH] cfq: Remove special treatment for metadata rqs Justin TerAvest
2011-06-20 19:55 ` Christoph Hellwig
2011-06-20 19:59 ` Jens Axboe
2011-06-20 20:03 ` Justin TerAvest
2011-06-20 20:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFFA814.40006@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teravest@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.