All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@linux.intel.com>
To: stefano.stabellini@eu.citrix.com
Cc: hpa@zytor.com, konrad.wilk@oracle.com, mingo@elte.hu,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	yinghai@kernel.org
Subject: Re: [PATCH 1/3] x86: calculate precisely the memory needed by init_memory_mapping
Date: Mon, 20 Jun 2011 15:37:33 -0700	[thread overview]
Message-ID: <4DFFCBAD.9040507@linux.intel.com> (raw)
In-Reply-To: <1307470409-7654-1-git-send-email-stefano.stabellini@eu.citrix.com>

On 06/07/2011 11:13 AM, stefano.stabellini@eu.citrix.com wrote:
> 
> - remove the extra page added on x86_32 for the fixmap because is not
> needed: the PMD entry is already allocated and contiguous for the whole
> range (a PMD page covers 4G of virtual addresses) and the pte entry is
> already allocated by early_ioremap_init.
> 

Hi Stefano,

I think this is wrong.  A PMD page covers *1G* of virtual addresses, and
in the 2+2 and 1+3 memory configurations, we may or may not need a
separate PMD for the fixmap.

Am I missing something?

	-hpa

  reply	other threads:[~2011-06-20 22:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07 18:13 [PATCH 0/3] x86: remove x86_init.mapping.pagetable_reserve Stefano Stabellini
2011-06-07 18:13 ` Stefano Stabellini
2011-06-07 18:13 ` [PATCH 1/3] x86: calculate precisely the memory needed by init_memory_mapping stefano.stabellini
2011-06-20 22:37   ` H. Peter Anvin [this message]
2011-06-21 17:57     ` Stefano Stabellini
2011-06-21 17:57       ` Stefano Stabellini
2011-06-21 18:02       ` H. Peter Anvin
2011-06-21 18:02         ` H. Peter Anvin
2011-06-21 20:37   ` [tip:x86/mm] x86, mm: Calculate " tip-bot for Stefano Stabellini
2011-06-07 18:13 ` [PATCH 2/3] Revert "x86,xen: introduce x86_init.mapping.pagetable_reserve" stefano.stabellini
2011-06-21 20:37   ` [tip:x86/mm] " tip-bot for Stefano Stabellini
2011-06-07 18:13 ` [PATCH 3/3] x86: move memblock_x86_reserve_range PGTABLE to find_early_table_space stefano.stabellini
2011-06-21 20:38   ` [tip:x86/mm] x86, init : Move " tip-bot for Stefano Stabellini
     [not found] ` <m2n.s.1QU0lc-137774@chiark.greenend.org.uk>
2011-06-17 17:11   ` [Xen-devel] [PATCH 1/3] x86: calculate precisely the memory needed by init_memory_mapping Ian Jackson
2011-06-17 17:11     ` Ian Jackson
2011-06-20 19:16     ` Stefano Stabellini
2011-06-20 19:16       ` Stefano Stabellini
2011-06-21 20:58 ` [PATCH 0/3] x86: remove x86_init.mapping.pagetable_reserve Ingo Molnar
2011-06-22 17:16   ` Stefano Stabellini
2011-06-22 17:16     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFFCBAD.9040507@linux.intel.com \
    --to=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.