All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Wong <andrew.w@sohovfx.com>
To: David Caldwell <david@porkrind.org>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] stash: Add --clean option to stash and remove all untracked files
Date: Tue, 21 Jun 2011 01:08:50 -0400	[thread overview]
Message-ID: <4E002762.3050803@sohovfx.com> (raw)
In-Reply-To: <4DFFF5AA.4030401@porkrind.org>

Ah, this patch will be very useful. I actually ran into several 
scenarios before where I wished stash could do exactly this.

On 11-06-20 9:36 PM, David Caldwell wrote:
> On 6/20/11 5:38 PM, Jeff King wrote:
>> Hmm. I think I would call this something like "--untracked", as to me
>> the main function is saving those files, not cleaning them afterwards
>> (the fact that they are cleaned is really just making the untracked-file
>> handling in line with what we do for tracked files; we put the changes
>> in the stash and remove them from the working tree).
>
> I see your point but I thought "--clean" was pretty descriptive of how
> the working dir ended up afterward. Maybe "git stash --everything" (or
> "--all")?
I personally think "--untracked" (and -u) is more intuitive too, since 
it tells you what "git stash" is about to do. i.e. "git stash" is about 
to do the usual stash operation *and* also stash the "untracked" files.
It seems more clear and precise than saying "git will stash my tree to a 
state that is clean", which doesn't exactly tell me how is that 
different from the usual stash.To me, "--clean" might even sounds more 
like "do a stash, and then do a clean", which doesn't make sense.

I would've liked "--all" too, except it reminds me too much of "git 
commit --all", which is just committing all tracked files.

Again, that's just my personal preference.

  reply	other threads:[~2011-06-21  5:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20 23:36 [PATCH] stash: Add --clean option to stash and remove all untracked files David Caldwell
2011-06-21  0:38 ` Jeff King
2011-06-21  1:36   ` David Caldwell
2011-06-21  5:08     ` Andrew Wong [this message]
2011-06-21  6:28       ` Johannes Sixt
2011-06-21 14:18         ` Jeff King
2011-06-21 16:11           ` Paul Ebermann
2011-06-21 21:23             ` Marc Branchaud
2011-06-22  7:47             ` Miles Bader
2011-06-22 15:00               ` Jeff King
2011-06-21 17:16           ` Junio C Hamano
2011-06-24 20:02 ` [PATCH] stash: Add --include-untracked " David Caldwell
2011-06-24 20:31   ` Matthieu Moy
2011-06-25  0:56     ` David Caldwell
2011-06-26 20:02       ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2011-06-22  5:49 [PATCH] stash: Add --clean " David Caldwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E002762.3050803@sohovfx.com \
    --to=andrew.w@sohovfx.com \
    --cc=david@porkrind.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.