From: Josef Bacik <josef@redhat.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dave@jikos.cz, chris.mason@oracle.com
Subject: Re: [PATCH 10/12 v3] Btrfs: deal with EEXIST after iput
Date: Tue, 21 Jun 2011 10:00:02 -0400 [thread overview]
Message-ID: <4E00A3E2.9030108@redhat.com> (raw)
In-Reply-To: <1308646193-7086-11-git-send-email-liubo2009@cn.fujitsu.com>
On 06/21/2011 04:49 AM, Liu Bo wrote:
> There are two cases when BTRFS_I(inode)->logged_trans is zero:
> a) an inode is just allocated;
> b) iput an inode and reread it.
>
> However, in b) if btrfs is not committed yet, and this inode _may_ still remain
> in log tree.
>
> So we need to check the log tree to get logged_trans a right value
> in case it hits a EEXIST while logging.
Instead of doing this why not just check and see if the inode has been
logged but the transaction has not yet been committed in
btrfs_drop_inode? That way the inode doesn't get evicted from cache
until after we know it's ok and that way we don't have to waste a tree
lookup. Thanks,
Josef
next prev parent reply other threads:[~2011-06-21 14:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 8:49 [GIT PULL v3] Btrfs: improve write ahead log with sub transaction Liu Bo
2011-06-21 8:49 ` [PATCH 01/12 v3] Btrfs: introduce sub transaction stuff Liu Bo
2011-06-21 8:49 ` [PATCH 02/12 v3] Btrfs: update block generation if should_cow_block fails Liu Bo
2011-06-21 8:49 ` [PATCH 03/12 v3] Btrfs: modify btrfs_drop_extents API Liu Bo
2011-06-21 8:49 ` [PATCH 04/12 v3] Btrfs: introduce first sub trans Liu Bo
2011-06-21 8:49 ` [PATCH 05/12 v3] Btrfs: still update inode trans stuff when size remains unchanged Liu Bo
2011-06-21 8:49 ` [PATCH 06/12 v3] Btrfs: improve log with sub transaction Liu Bo
2011-06-21 13:46 ` Josef Bacik
2011-06-21 8:49 ` [PATCH 07/12 v3] Btrfs: add checksum check for log Liu Bo
2011-06-21 13:49 ` Josef Bacik
2011-06-21 8:49 ` [PATCH 08/12 v3] Btrfs: fix a bug of log check Liu Bo
2011-06-21 8:49 ` [PATCH 09/12 v3] Btrfs: kick off useless code Liu Bo
2011-06-21 8:49 ` [PATCH 10/12 v3] Btrfs: deal with EEXIST after iput Liu Bo
2011-06-21 14:00 ` Josef Bacik [this message]
2011-06-22 1:57 ` liubo
2011-06-21 8:49 ` [PATCH 11/12 v3] Btrfs: use the right generation number to read log_root_tree Liu Bo
2011-06-21 8:49 ` [PATCH 12/12 v3] Revert "Btrfs: do not flush csum items of unchanged file data during treelog" Liu Bo
2011-08-04 13:57 ` [GIT PULL v3] Btrfs: improve write ahead log with sub transaction Chris Mason
2011-08-06 3:44 ` liubo
2011-08-06 9:23 ` liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E00A3E2.9030108@redhat.com \
--to=josef@redhat.com \
--cc=chris.mason@oracle.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.