From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: MMU: make kvm_mmu_reset_context() flush the guest TLB
Date: Tue, 21 Jun 2011 17:29:59 +0300 [thread overview]
Message-ID: <4E00AAE7.2090004@redhat.com> (raw)
In-Reply-To: <20110620183234.GB19717@amt.cnet>
On 06/20/2011 09:32 PM, Marcelo Tosatti wrote:
> On Sun, Jun 12, 2011 at 06:25:00PM +0300, Avi Kivity wrote:
> > kvm_set_cr0() and kvm_set_cr4(), and possible other functions,
> > assume that kvm_mmu_reset_context() flushes the guest TLB. However,
> > it does not.
>
> TLB flush should be done lazily during guest entry, in
> kvm_mmu_load(). Don't see why this patch is needed.
You're right. It should be reverted.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2011-06-21 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 15:25 [PATCH] KVM: MMU: make kvm_mmu_reset_context() flush the guest TLB Avi Kivity
2011-06-20 18:32 ` Marcelo Tosatti
2011-06-21 14:29 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E00AAE7.2090004@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.