From: Antti Palosaari <crope@iki.fi>
To: David <reality_es@yahoo.es>
Cc: linux-media@vger.kernel.org
Subject: Re: Sveon stv22 patches
Date: Wed, 22 Jun 2011 13:59:10 +0300 [thread overview]
Message-ID: <4E01CAFE.9070801@iki.fi> (raw)
In-Reply-To: <BANLkTimY_RKO4TxSu5GQo84_7VCMjLEFDg@mail.gmail.com>
Hello
Comments below.
Could you use Git since you have latest Kernel? If that's too hard don't
try it, I can leave without, but it will easy my work a little.
You have diffed wrong direction, those patches are removing lines rather
than adding (- vs. +). Also you your signed off by is needed.
See:
http://linuxtv.org/wiki/index.php/Development:_Submitting_Patches
> --- ./rc-map.h 2011-06-21 11:16:55.000000000 +0200
> +++ ./include/media/rc-map.h 2011-06-21 12:41:34.114509214 +0200
> @@ -130,7 +130,6 @@
> #define RC_MAP_RC6_MCE "rc-rc6-mce"
> #define RC_MAP_REAL_AUDIO_220_32_KEYS "rc-real-audio-220-32-keys"
> #define RC_MAP_STREAMZAP "rc-streamzap"
> -#define RC_MAP_SVEON_STV22 "rc-msi-digivox-iii"
> #define RC_MAP_TBS_NEC "rc-tbs-nec"
> #define RC_MAP_TECHNISAT_USB2 "rc-technisat-usb2"
> #define RC_MAP_TERRATEC_CINERGY_XS "rc-terratec-cinergy-xs"
That's wrong, it is not needed at all. All the other seems to be rather OK.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-06-22 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 10:36 Sveon stv22 patches David
2011-06-22 10:59 ` Antti Palosaari [this message]
2011-06-22 17:45 ` David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E01CAFE.9070801@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=reality_es@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.