All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel.bbclass: restore kernel-abiversion file
Date: Wed, 22 Jun 2011 11:13:16 -0700	[thread overview]
Message-ID: <4E0230BC.6020404@linux.intel.com> (raw)
In-Reply-To: <1308757294-21106-1-git-send-email-koen@dominion.thruhere.net>



On 06/22/2011 08:41 AM, Koen Kooi wrote:
> This fixes external module recipes that need $KERNEL_VERSION. It got removed by
> 
>     commit a9d41062e24a6b99661b3a5256f369b557433607
>     Author: Darren Hart <dvhart@linux.intel.com>
>     Date:   Tue Mar 8 17:09:10 2011 -0800
> 
>         kernel/bbclass: rework kernel and module classes to allow for building out-of-tree modules
> 
> seemingly as an oversight.
> 
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/classes/kernel.bbclass |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 1bb69f5..8f9f108 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -123,6 +123,12 @@ kernel_do_install() {
>  	install -d $kerneldir
>  
>  	#
> +	# Store the kernel version in sysroots for module-base.bbclass
> +	#
> +
> +	echo "${KERNEL_VERSION}" > $kerneldir/kernel-abiversion

From everything I can see this is an openembedded construct - which
external modules need this? An example recipe I can review?

I'd like to understand this better as I don't like the idea of depending
on an arbitrary file that isn't part of the kernel build system to build
modules.

It seems to me that these modules should be able to DEPEND on something
provided by the kernel recipes, rather than checking the contents of a
file stuck in the build tree.

--
Darren

> +
> +	#
>  	# Copy the entire source tree. In case an external build directory is
>  	# used, copy the build directory over first, then copy over the source
>  	# dir. This ensures the original Makefiles are used and not the

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel



  reply	other threads:[~2011-06-22 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 15:41 [PATCH] kernel.bbclass: restore kernel-abiversion file Koen Kooi
2011-06-22 18:13 ` Darren Hart [this message]
2011-06-22 18:18   ` Koen Kooi
2011-06-22 19:08     ` Darren Hart
2011-06-23 12:35 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0230BC.6020404@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.