Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start

[Wayne Xia <xiawenc@linux.vnet.ibm.com>]

2011-6-23 18:03, Jan Kiszka
> On 2011-06-23 11:18, Wayne Xia wrote:
>> Hi,
>>      these 3 patch simply enable qemu-kvm to show a logo picture when it
> 
> You are posting on qemu-devel (which is correct for this topic), so your
> patches must target that tree. Patch 1 eg. does not and needs rebasing.
> 
thanks for the tip.
>> s start up, following is how to configurate it:
>>      invoke it with params:
>>      -boot (splash_time=<N>,) (splash_filename=<N>,)
> 
> Simply 'splash' for specifying the file should suffice.
> 
>>      the splash_time is in the unit of ms, and its max value is 65535.
>> this feature is by default on with 5000ms showing up.
> 
> Strong NAK for making this default. We have a nice sub-second BIOS time
> in QEMU, and that must not be destroyed by eye candy. 5 s is also way
> too long even when you want splash.
> 
Maybe 5 is a bit too long, this patch is for test so made it a bit
longer to be observed by VNC, I think 2.5s would be fit.

>>      Patch 1 contains the source modification for qemu-kvm, Patch 2 and
>> 3 are binary patches that added a default logo picture file, alternated
>> the bios.bin to make the sea-bios showing it. Patch 3 is just used to
>> provide a convenient way to test the Patch, waiting for newer version
>> of seabios that provide the support officially.
>>      Any comments would be very nice.
> 
> - commit logs a missing in the individual patches
I think patch 3/3 may be in the junk mail box.
> - the BIOS is updated via submodule reference, and that only to SeaBIOS
> releases (IOW,
>    you can only provide a test image so far, no patch)
> - a default logo should not mention KVM but QEMU (splash is not limited
> to KVM mode)
we can switch it for a more official picture for different release.

> Jan
> 


-- 
Best Regards

Wayne Xia
mail:xiawenc@linux.vnet.ibm.com
tel:86-010-82450803