From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZlNa-0006bG-6T for qemu-devel@nongnu.org; Thu, 23 Jun 2011 10:59:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZlNY-0001z7-Om for qemu-devel@nongnu.org; Thu, 23 Jun 2011 10:59:38 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:45268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZlNY-0001yv-6T for qemu-devel@nongnu.org; Thu, 23 Jun 2011 10:59:36 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5NEuRaw017530 for ; Thu, 23 Jun 2011 08:56:27 -0600 Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p5NEx4M6091484 for ; Thu, 23 Jun 2011 08:59:06 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5NF4P3s011102 for ; Thu, 23 Jun 2011 09:04:25 -0600 Message-ID: <4E0354B7.9080902@us.ibm.com> Date: Thu, 23 Jun 2011 09:59:03 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4E030501.3040105@linux.vnet.ibm.com> <20110623120029.GA11202@amd.home.annexia.org> In-Reply-To: <20110623120029.GA11202@amd.home.annexia.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: Wayne Xia , qemu-devel@nongnu.org On 06/23/2011 07:00 AM, Richard W.M. Jones wrote: > On Thu, Jun 23, 2011 at 05:18:57PM +0800, Wayne Xia wrote: >> Hi, >> these 3 patch simply enable qemu-kvm to show a logo picture when it >> s start up, following is how to configurate it: >> invoke it with params: >> -boot (splash_time=,) (splash_filename=,) >> the splash_time is in the unit of ms, and its max value is 65535. >> this feature is by default on with 5000ms showing up. >> Patch 1 contains the source modification for qemu-kvm, Patch 2 and >> 3 are binary patches that added a default logo picture file, alternated >> the bios.bin to make the sea-bios showing it. Patch 3 is just used to >> provide a convenient way to test the Patch, waiting for newer version >> of seabios that provide the support officially. >> Any comments would be very nice. > > Splash screens are a terrible idea. No, they're not. > We should work instead on making the boot even faster. Having the ability to have an optional splash screen does not slow down boot for the cases when it's not enabled. It's extremely valuable in many use-cases to enable branding. > And having it *default* to 5 seconds! That's like, nearly double the > time it takes to launch libguestfs completely!! No one is saying that libguestfs has to enable a splash screen during it's guest start up. Regards, Anthony Liguori > Please don't accept these patches. > > Rich. >