From: Michal Marek <mmarek@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
Nick Bowler <nbowler@elliptictech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Frysinger <vapier@gentoo.org>,
Sam Ravnborg <sam@ravnborg.org>,
Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Subject: Re: __packed vs. __attribute__((packed)) in kernel headers
Date: Fri, 24 Jun 2011 15:07:25 +0200 [thread overview]
Message-ID: <4E048C0D.7020403@suse.cz> (raw)
In-Reply-To: <1308848277.6688.7.camel@Joe-Laptop>
On 23.6.2011 18:57, Joe Perches wrote:
> On Thu, 2011-06-23 at 17:02 +0200, Markus Trippelsdorf wrote:
>> On 2011.06.23 at 09:42 -0400, Nick Bowler wrote:
>>> On 2011-06-22 08:34 +0200, Markus Trippelsdorf wrote:
>>>> One possible solution would be to let the "scripts/headers_install.pl"
>>>> script automatically substitute __packed with __attribute__((packed)):
>>>>
>>>> diff --git a/scripts/headers_install.pl b/scripts/headers_install.pl
> []
>> I'm not an expert of Perl regular expressions, but maybe this:
>> $line =~ s/\s__packed;$/ __attribute__((packed));/g
>> is a little bit closer to the intention?
>
> Maybe:
>
> s/\b__packed\b/__attribute__((packed))/g
Markus, will you post a patch with this fix?
> though this argues against redefining
> gcc __attributes__ in the first place.
It's a handy shortcut, so why not have it. Although I don't understand
why checkpatch.pl has to warn about __attribute__((packed)).
Michal
next prev parent reply other threads:[~2011-06-24 13:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 6:34 __packed vs. __attribute__((packed)) in kernel headers Markus Trippelsdorf
2011-06-23 13:42 ` Nick Bowler
2011-06-23 15:02 ` Markus Trippelsdorf
2011-06-23 16:57 ` Joe Perches
2011-06-24 13:07 ` Michal Marek [this message]
2011-06-24 13:51 ` {PATCH] fix __packed in exported " Markus Trippelsdorf
2011-06-24 15:17 ` Michal Marek
2011-06-24 16:33 ` Arnd Bergmann
2011-06-24 17:00 ` Mike Frysinger
2011-06-30 18:26 ` H. Peter Anvin
2011-06-30 18:48 ` Mike Frysinger
2011-06-30 18:52 ` H. Peter Anvin
2011-06-30 18:58 ` Mike Frysinger
2011-06-30 19:01 ` H. Peter Anvin
2011-06-30 19:13 ` Mike Frysinger
2011-06-30 20:02 ` H. Peter Anvin
2011-06-30 21:56 ` Mike Frysinger
2011-06-24 17:01 ` Markus Trippelsdorf
2011-06-23 17:04 ` __packed vs. __attribute__((packed)) in " richard -rw- weinberger
2011-06-23 17:46 ` Markus Trippelsdorf
2011-06-23 17:54 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E048C0D.7020403@suse.cz \
--to=mmarek@suse.cz \
--cc=Artem.Bityutskiy@nokia.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=nbowler@elliptictech.com \
--cc=sam@ravnborg.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.