From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH] usb-hid: Fix 0/0 position for Windows in tablet mode
Date: Fri, 24 Jun 2011 16:27:03 +0200 [thread overview]
Message-ID: <4E049EB7.4010309@siemens.com> (raw)
For unknown reasons, Windows drivers (tested with XP and Win7) ignore
usb-tablet events that move the pointer to 0/0. So always set bit 0 of
the coordinates.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/usb-hid.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/usb-hid.c b/hw/usb-hid.c
index d711b5c..2b9a451 100644
--- a/hw/usb-hid.c
+++ b/hw/usb-hid.c
@@ -457,8 +457,10 @@ static void usb_pointer_event_combine(USBPointerEvent *e, int xyrel,
e->xdx += x1;
e->ydy += y1;
} else {
- e->xdx = x1;
- e->ydy = y1;
+ /* Windows drivers do not like the 0/0 position and ignore such
+ * events. */
+ e->xdx = x1 | 1;
+ e->ydy = y1 | 1;
}
e->dz += z1;
}
next reply other threads:[~2011-06-24 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 14:27 Jan Kiszka [this message]
2011-06-25 12:37 ` [Qemu-devel] [PATCH] usb-hid: Fix 0/0 position for Windows in tablet mode Andreas Färber
2011-06-25 12:55 ` Jan Kiszka
2011-06-25 13:10 ` Andreas Färber
2011-06-26 9:11 ` Jan Kiszka
2011-07-04 18:15 ` andrzej zaborowski
2011-07-12 7:47 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2011-07-13 21:05 ` Andreas Färber
2011-07-30 5:51 ` andrzej zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E049EB7.4010309@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.