All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits
Date: Sat, 25 Jun 2011 08:08:19 +0200	[thread overview]
Message-ID: <4E057B53.9080700@redhat.com> (raw)
In-Reply-To: <201106251015.42820.bradh@frogmouth.net>

Hi,

On 06/25/2011 02:15 AM, Brad Hards wrote:
> 5/11 does this:
> -#define PORTSC_RO_MASK       0x007021c5
> +#define PORTSC_RO_MASK       0x007021c4
>
> before 8/11 does this:
>> -#define PORTSC_RO_MASK       0x007021c4
>> +#define PORTSC_RO_MASK       0x007021c0
>
> You could push those together if there was a v2. I don't think its important
> though.
>

I would rather keep them separate, they happen to
touch the same define, but for completely different
reasons.

Regards,

Hans

  reply	other threads:[~2011-06-25  6:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24 19:32 [Qemu-devel] RFC/PULL: usb: add support for companion controllers Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 01/11] usb: Add a register_companion USB bus op Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 02/11] usb: Make port wakeup and complete ops take a USBPort instead of a Device Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 03/11] usb: Replace device_destroy bus op with a child_detach port op Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 04/11] usb-ehci: drop unused num-ports state member Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 05/11] usb-ehci: Connect Status bit is read only, don't allow changing it by the guest Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 06/11] usb-ehci: cleanup port reset handling Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 07/11] usb: assert on calling usb_attach(port, NULL) on a port without a dev Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits Hans de Goede
2011-06-25  0:15   ` Brad Hards
2011-06-25  6:08     ` Hans de Goede [this message]
2011-06-24 19:32 ` [Qemu-devel] [PATCH 09/11] usb-ehci: Add support for registering companion controllers Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 10/11] usb-uhci: Add support for being a companion controller Hans de Goede
2011-06-29 10:57   ` Gerd Hoffmann
2011-06-29 11:19     ` Hans de Goede
2011-06-29 12:29       ` Gerd Hoffmann
2011-06-30 11:09         ` Hans de Goede
2011-06-24 19:32 ` [Qemu-devel] [PATCH 11/11] usb-ohci: " Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E057B53.9080700@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.