From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSOL-0002hM-Rt for qemu-devel@nongnu.org; Sat, 25 Jun 2011 08:55:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaSOK-0007hh-3T for qemu-devel@nongnu.org; Sat, 25 Jun 2011 08:55:17 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:33954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaSOJ-0007hX-IP for qemu-devel@nongnu.org; Sat, 25 Jun 2011 08:55:15 -0400 Message-ID: <4E05DAAC.7040905@web.de> Date: Sat, 25 Jun 2011 14:55:08 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E049EB7.4010309@siemens.com> <0A671AC2-4669-462A-A704-12D94A3D5ACB@web.de> In-Reply-To: <0A671AC2-4669-462A-A704-12D94A3D5ACB@web.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF51AA2B4AEF49C3F066D6735" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] usb-hid: Fix 0/0 position for Windows in tablet mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel , Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF51AA2B4AEF49C3F066D6735 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-06-25 14:37, Andreas F=E4rber wrote: > Am 24.06.2011 um 16:27 schrieb Jan Kiszka: >=20 >> For unknown reasons, Windows drivers (tested with XP and Win7) ignore >> usb-tablet events that move the pointer to 0/0. So always set bit 0 of= >> the coordinates. >> >> Signed-off-by: Jan Kiszka >> --- >> hw/usb-hid.c | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/hw/usb-hid.c b/hw/usb-hid.c >> index d711b5c..2b9a451 100644 >> --- a/hw/usb-hid.c >> +++ b/hw/usb-hid.c >> @@ -457,8 +457,10 @@ static void >> usb_pointer_event_combine(USBPointerEvent *e, int xyrel, >> e->xdx +=3D x1; >> e->ydy +=3D y1; >> } else { >> - e->xdx =3D x1; >> - e->ydy =3D y1; >> + /* Windows drivers do not like the 0/0 position and ignore su= ch >> + * events. */ >> + e->xdx =3D x1 | 1; >> + e->ydy =3D y1 | 1; >=20 > Doesn't this change mean we can't access any other even pixel either? Only on 32767x32767 screens (that's the resolution of the tablet). Jan --------------enigF51AA2B4AEF49C3F066D6735 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk4F2q8ACgkQitSsb3rl5xQhBACfZrs9blUgzbIfK1YkiAgORoIZ LrwAoLE332Bh5epFb4LhIFEwH0bD7SG5 =sEl0 -----END PGP SIGNATURE----- --------------enigF51AA2B4AEF49C3F066D6735--