From: Joel A Fernandes <agnel.joel@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ehci-hcd: Allow cleanups to happen on an EHCI timeout.
Date: Sat, 25 Jun 2011 14:28:16 -0500 [thread overview]
Message-ID: <4E0636D0.9010107@gmail.com> (raw)
In-Reply-To: <D6885F5E-CA69-451D-B111-36836A0164E0@beagleboard.org>
With this, the EHCI seems to "recover" from a timeout. This is particularly
observable if you were to ping the wrong IP Address and then ping the correct
one or if there was a temporary failure during tftp sessions.
All it takes is one timeout to disable it. If you have a noisy network (lot
of traffic), even if the traffic is not for the board, the timeouts don't occur.
Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
Robert, Could you see if this patch solves the issue you're seeing without
increasing the timeout?
Simon, Could this be a fix for a similar issue you were seeing with asix?
drivers/usb/host/ehci-hcd.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 243bb39..9bfcbae 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -464,7 +464,6 @@ ehci_submit_async(struct usb_device *dev, unsigned long pipe, void *buffer,
/* Check that the TD processing happened */
if (token & 0x80) {
printf("EHCI timed out on TD - token=%#x\n", token);
- goto fail;
}
/* Disable async schedule. */
--
1.7.1
next parent reply other threads:[~2011-06-25 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D6885F5E-CA69-451D-B111-36836A0164E0@beagleboard.org>
2011-06-25 19:28 ` Joel A Fernandes [this message]
2011-06-26 8:04 ` [U-Boot] [PATCH] ehci-hcd: Allow cleanups to happen on an EHCI timeout Robert Berger
2011-07-28 23:22 ` 2bluesc at gmail.com
2011-06-29 22:32 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0636D0.9010107@gmail.com \
--to=agnel.joel@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.