All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: TeLeMan <geleman@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>, Roy Tam <roytam@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified
Date: Mon, 27 Jun 2011 07:40:03 +0200	[thread overview]
Message-ID: <4E0817B3.50109@mail.berlios.de> (raw)
In-Reply-To: <BANLkTikp8PZoZVbeuHVgDsH2mpLxKs+ytg@mail.gmail.com>

Am 27.06.2011 04:37, schrieb TeLeMan:
> This patch breaks the compilation with --enable-vnc-png:
>
> CC ui/vnc-enc-tight.o
> In file included from /usr/include/png.h:518,
> from ui/vnc-enc-tight.c:34:
> /usr/include/pngconf.h:371: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before '.' token
> /usr/include/pngconf.h:372: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'include'
> make: *** [ui/vnc-enc-tight.o] Error 1
>
> --
> SUN OF A BEACH

I get the same compiler error when I run with --enable-vnc-png,
and the buildbots got it as well. In my last test, png support
was disabled, so I did not notice this problem.

The png header files check for prior inclusion of setjmp.h
and have a really surprising way of telling that this happened
(instead of #error, they use illegal C code - a comment without
comment delimiters).

A patch which disables this strange check was just sent to qemu-devel.

Regards,
Stefan

  parent reply	other threads:[~2011-06-27  5:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-18  5:13 [Qemu-devel] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified Roy Tam
2011-06-18  8:35 ` [Qemu-trivial] " Stefan Weil
2011-06-18  8:35   ` Stefan Weil
2011-06-23 13:52   ` [Qemu-trivial] " Stefan Hajnoczi
2011-06-23 13:52     ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-06-23 15:05     ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2011-06-23 15:05       ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
2011-06-24  5:30       ` [Qemu-trivial] [Qemu-devel] " Stefan Hajnoczi
2011-06-24  5:30         ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2011-06-26 18:06       ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
2011-06-26 18:06         ` [Qemu-devel] [Qemu-trivial] " Blue Swirl
2011-06-26 20:03         ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2011-06-26 20:03           ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
2011-06-26 20:26           ` [Qemu-trivial] [Qemu-devel] " Blue Swirl
2011-06-26 20:26             ` [Qemu-devel] [Qemu-trivial] " Blue Swirl
2011-06-27  2:37             ` [Qemu-trivial] [Qemu-devel] " TeLeMan
2011-06-27  2:37               ` [Qemu-devel] [Qemu-trivial] " TeLeMan
2011-06-27  4:15               ` [Qemu-trivial] [Qemu-devel] " Roy Tam
2011-06-27  4:15                 ` [Qemu-devel] [Qemu-trivial] " Roy Tam
2011-06-27  5:40               ` Stefan Weil [this message]
2011-06-27  5:56                 ` Roy Tam
2011-06-27 17:22                   ` Stefan Weil
2011-06-30 15:26                     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0817B3.50109@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=blauwirbel@gmail.com \
    --cc=geleman@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=roytam@gmail.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.