From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:32882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Qb68W-0004BU-UE
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 03:21:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Qb68V-0008Kc-BV
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 03:21:36 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:58497)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Qb68U-0008KN-QZ
	for qemu-devel@nongnu.org; Mon, 27 Jun 2011 03:21:35 -0400
Message-ID: <4E082F7B.3080800@web.de>
Date: Mon, 27 Jun 2011 09:21:31 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <1309157611-31078-1-git-send-email-xiawenc@linux.vnet.ibm.com>
In-Reply-To: <1309157611-31078-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig9412AC80203366060C21CCB7"
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PATCH v3] showing a splash picture when start
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wayne Xia <xiawenc@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig9412AC80203366060C21CCB7
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-06-27 08:53, Wayne Xia wrote:
> Made an option to let qemu pass a picture to bios, let the bios show it=
 as a=20
> logo. By default it is off, enable it as following

That's better. :)

>     -boot splash_time=3DN,splash_filename=3DP
> N have a max value of 0xffff, unit is ms. P is the a file name or a abs=
olute=20
> path.
> Currently a trial version of sea-bios could be used to test it.
>=20
> Signed-off-by: Wayne Xia <xiawenc@linux.vnet.ibm.com>
> ---

=2E..

> index c63741c..6f93b10 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -469,6 +469,32 @@ static QemuOptsList qemu_machine_opts =3D {
>      },
>  };
> =20
> +QemuOptsList qemu_bootsplash_opts =3D {
> +    .name =3D "bootsplash",
> +    .head =3D QTAILQ_HEAD_INITIALIZER(qemu_bootsplash_opts.head),
> +    .desc =3D {
> +        /* the three names below are not used now */
> +        {
> +            .name =3D "order",
> +            .type =3D QEMU_OPT_STRING,
> +        }, {
> +            .name =3D "once",
> +            .type =3D QEMU_OPT_STRING,
> +        }, {
> +            .name =3D "menu",
> +            .type =3D QEMU_OPT_STRING,
> +        /* following are really used */
> +        }, {
> +            .name =3D "splash_time",
> +            .type =3D QEMU_OPT_STRING,
> +        }, {
> +            .name =3D "splash_filename",
> +            .type =3D QEMU_OPT_STRING,
> +        },
> +        { /*End of list */ }
> +    },
> +};
> +

This is describing the "boot" option that also controls the splash.
Naming should reflect this.

Jan


--------------enig9412AC80203366060C21CCB7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk4IL3sACgkQitSsb3rl5xQOFgCgtjPJIqu612ch+O9BcXEx1fDg
lKgAoNbtQTxUIVaNSiG6aM5yc1uJJIyZ
=kDp+
-----END PGP SIGNATURE-----

--------------enig9412AC80203366060C21CCB7--