From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH 0 of 5] v2: Nested-p2m cleanups and locking
	changes
Date: Mon, 27 Jun 2011 15:24:05 +0200
Message-ID: <4E088475.2030201@amd.com>
References: <patchbomb.1309171570@whitby.uk.xensource.com>
	<20110627105654.GK17634@whitby.uk.xensource.com>
	<4E08762A.2050801@amd.com>
	<20110627131528.GN17634@whitby.uk.xensource.com>
	<20110627132052.GO17634@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20110627132052.GO17634@whitby.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 06/27/11 15:20, Tim Deegan wrote:
> At 14:15 +0100 on 27 Jun (1309184128), Tim Deegan wrote:
>> At 14:23 +0200 on 27 Jun (1309184586), Christoph Egger wrote:
>>>>   - Why is there a 10x increase in IPIs after this series?  I don't see
>>>>     what sequence of events sets the relevant cpumask bits to make this
>>>>     happen.
>>>
>>> In patch 1 the code that sends the IPIs was outside of the loop and
>>> moved into the loop.
>>
>> Well, yes, but I don't see what that causes 10x IPIs, unless the vcpus
>> are burning through np2m tables very quickly indeed.  Maybe removing the
>> extra flushes for TLB control will do the trick.  I'll make a patch...
>
> Hmmm, on second thoughts, we can't remove those flushes after all.
> The np2m is in sync with the p2m but not with the guest-supplied p2m,
> so we do need to flush it when the guest asks for that to happen.

Right. I thought on that when I developped the code but then I forgot.
We should add a comment.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632