From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbCiy-0005BJ-NJ for qemu-devel@nongnu.org; Mon, 27 Jun 2011 10:23:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbCix-0003pT-3R for qemu-devel@nongnu.org; Mon, 27 Jun 2011 10:23:40 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:57135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbCiw-0003pE-I0 for qemu-devel@nongnu.org; Mon, 27 Jun 2011 10:23:38 -0400 Message-ID: <4E08925F.3030605@adacore.com> Date: Mon, 27 Jun 2011 16:23:27 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1309178511-20027-1-git-send-email-chouteau@adacore.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimum List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org On 27/06/2011 15:50, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2011 at 1:41 PM, Fabien Chouteau wrote: >> >> Signed-off-by: Fabien Chouteau >> --- >> slirp/slirp.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) > > Any particular bug that this fixes? > > There have been 64 byte minimum padding patches to several emulated > NICs. There has also been discussion about where the best place to do > this is. Why is this patch necessary? > This patch is necessary because some NICs are configured to drop short frames, therefore the OS will not receive some of the packets generated by Qemu. There's a first patch to fix this issue: http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=dbf3c4b4baceb91eb64d09f787cbe92d65188813 My patch fixes two other sources of short frames. -- Fabien Chouteau