From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Roskin Subject: Re: [PATCH -next] bcma: main.c needs to include Date: Mon, 27 Jun 2011 10:44:00 -0400 Message-ID: <4E089730.1080306@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexey Dobriyan Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Geert Uytterhoeven , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Development List-Id: linux-next.vger.kernel.org On 06/27/2011 10:24 AM, Alexey Dobriyan wrote: > 2011/6/27 Rafa=C5=82 Mi=C5=82ecki: >> 2011/6/26 Geert Uytterhoeven: >>> m68k allmodconfig: >>> >>> drivers/bcma/main.c: In function =E2=80=98bcma_release_core_dev=E2=80= =99: >>> drivers/bcma/main.c:68: error: implicit declaration of function =E2= =80=98kfree=E2=80=99 >> >> We already include slab.h in: >> host_pci.c >> scan.c >> sprom.c >> >> Maybe we can just include this in bcma.h as a better solution? > > It isn't better solution. > It results in situation where unnecessary inclusion will be done. > Maybe it's not the case now, but it will be in future. I agree. kfree() is used in main.c, not in bcma.h. There is no need=20 for all files that include bcma.h to include linux/slab.h, especially=20 (but not only) because bcma.h is not a private header. --=20 Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from c60.cesmail.net ([216.154.195.49]:27592 "EHLO c60.cesmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991Ab1F0Ooa (ORCPT ); Mon, 27 Jun 2011 10:44:30 -0400 Message-ID: <4E089730.1080306@gnu.org> (sfid-20110627_164435_066557_BA00BEDF) Date: Mon, 27 Jun 2011 10:44:00 -0400 From: Pavel Roskin MIME-Version: 1.0 To: Alexey Dobriyan CC: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Geert Uytterhoeven , linux-wireless@vger.kernel.org, linux-next@vger.kernel.org, Linux Kernel Development Subject: Re: [PATCH -next] bcma: main.c needs to include References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/27/2011 10:24 AM, Alexey Dobriyan wrote: > 2011/6/27 Rafał Miłecki: >> 2011/6/26 Geert Uytterhoeven: >>> m68k allmodconfig: >>> >>> drivers/bcma/main.c: In function ‘bcma_release_core_dev’: >>> drivers/bcma/main.c:68: error: implicit declaration of function ‘kfree’ >> >> We already include slab.h in: >> host_pci.c >> scan.c >> sprom.c >> >> Maybe we can just include this in bcma.h as a better solution? > > It isn't better solution. > It results in situation where unnecessary inclusion will be done. > Maybe it's not the case now, but it will be in future. I agree. kfree() is used in main.c, not in bcma.h. There is no need for all files that include bcma.h to include linux/slab.h, especially (but not only) because bcma.h is not a private header. -- Regards, Pavel Roskin