From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1QbEXA-0003Wr-0w for mharc-grub-devel@gnu.org; Mon, 27 Jun 2011 12:19:36 -0400 Received: from eggs.gnu.org ([140.186.70.92]:59216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbEX6-0003W3-Pw for grub-devel@gnu.org; Mon, 27 Jun 2011 12:19:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbEX5-0006nJ-3i for grub-devel@gnu.org; Mon, 27 Jun 2011 12:19:32 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:60192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbEX4-0006mw-Lp for grub-devel@gnu.org; Mon, 27 Jun 2011 12:19:30 -0400 Received: by wyg36 with SMTP id 36so4047577wyg.0 for ; Mon, 27 Jun 2011 09:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:x-enigmail-version:content-type; bh=W3oZ/WBTHMuTqz5CYVvEVGi+qywuec5o6P07QXJCKs8=; b=B2GD7Gf90L5UKYLJVlTZMI3rnIFBxm1J/R16qHA9go2KFSq+QUCEpIub5Q55CL8C0y JRWZzlEOnWC9ePSe907Pviy3bj7nt8B0ALCPPJPDaG7VeHVED4557H0JOqbNv+79fmlD j2qhJFo7r6BvPLDRCaZAYsP18u1T5hAlfNLiY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=ER+52OKj5XAm2Mm6um9Yb5akQZKVWZTRKXWXGiWhc8UPfDDJrP8nasvPRmD32dqaUH zt5H9j++N9fcH/FqfFCjO3JCjWYzTjcA80Np22eQ0ikbOPOEMGMvjvpBpRcbnZB38CG5 QVhhFi5hsJIhXd5t1n0Gnf/ZEnaTV+bR76SU8= Received: by 10.227.11.143 with SMTP id t15mr5678903wbt.56.1309191569498; Mon, 27 Jun 2011 09:19:29 -0700 (PDT) Received: from debian.x201.phnet (gprs07.swisscom-mobile.ch [193.247.250.7]) by mx.google.com with ESMTPS id fr17sm4202837wbb.40.2011.06.27.09.19.27 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Jun 2011 09:19:28 -0700 (PDT) Message-ID: <4E08AD8B.7020407@gmail.com> Date: Mon, 27 Jun 2011 18:19:23 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110606 Iceowl/1.0b2 Icedove/3.1.10 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: r3172 regresses background_color handling References: <20110627154614.GX23533@riva.ucam.org> In-Reply-To: <20110627154614.GX23533@riva.ucam.org> X-Enigmail-Version: 1.1.2 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8FF7E9FDEC53373BF70588C9" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 16:19:34 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8FF7E9FDEC53373BF70588C9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 27.06.2011 17:46, Colin Watson wrote: > This commit: > > revno: 3172 > committer: Vladimir 'phcoder' Serbinenko > branch nick: grub > timestamp: Wed 2011-04-06 13:00:18 +0200 > message: > Output errors if theme loading failed. > > * grub-core/gfxmenu/gfxmenu.c (grub_gfxmenu_try): Move the call= to > grub_gfxterm_fullscreen on error paths to ... > * grub-core/normal/menu.c (menu_init): ...here. Wait after show= ing > theme loading error. > > ... regresses the handling of background_color: grub_gfxterm_fullscreen= > sets up the virtual screen again, including setting the background > colour back to black, and now it's called every time we re-enter the > menu. Two simple ways to reproduce this are: > > 1) Put 'background_color 44,0,30' before the menuentry commands in > grub.cfg. The menu should show up with a purple background, but i= n > fact is black. > > 2) From a menu, press 'c' for a command line, then enter > 'background_color 44,0,30', which should turn the screen purple. > Now press Escape to go back to the menu. The background should > stay purple, but in fact turns black. > > What's the best fix for this? grub_gfxterm_fullscreen can run before > the virtual screen is set up, so I don't think I can just use > virtual_screen.bg_color_display. Can we go back to having > grub_gfxterm_fullscreen called once on startup and then only on error > paths, which I think was the previous behaviour? The reason to run it there is to avoid that gfxterm stays in some stuck mode if theme loading fails midway. > Thanks, > --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig8FF7E9FDEC53373BF70588C9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk4IrYsACgkQNak7dOguQgn/owEAs3emF2NmA80jw+KgLCkljMex 6UfGgAD1Ves8j+dI6WwA+wZ8REsIGVb6VUwzFztuXzxI2/YReEGeIg/2juvT1jOU =t18U -----END PGP SIGNATURE----- --------------enig8FF7E9FDEC53373BF70588C9--