Re: [PATCH 0/7] serial/8250: I/O accessor cleanups

[David Daney <david.daney@cavium.com>]

On 06/27/2011 02:45 PM, Arnd Bergmann wrote:
> Hi Greg,
>
> This series of patches cleans up the part of the 8250 device
> driver that is responsible for accessing the hardware registers.
> The driver defines all sorts of methods to do that right now,
> when it really should only support memory mapped and programmed
> I/O by default, and the latter only on PC-compatible platforms
> including those that have ISA/PCMCIA/PCI buses.
>
> The series shrinks the 8250 driver by about 10% in both binary
> and source code size, hopefully with no loss of functionality,
> and it allows platforms to no longer define bogus inb/outb
> functions when they don't provide CONFIG_HAS_IOPORT. I've
> build-tested for x86 and ARM with and without HAS_IOPORT.
>
> Hopefully Ralf can provide some feedback about the three
> MIPS platforms that have code changed by this.
>
> 	Arnd
>
> Arnd Bergmann (7):
>    serial/8250: remove obsolete RM9000 port type
>    serial/8250: move alchemy I/O handler to platform code
>    serial/8250: move UPIO_TSI to powerpc
>    serial/8250: move DWAP support to arch/mips
>    serial/8250: remove obsolete and broken PORT_RSA support
>    serial/8250: sanitize fourport handling
>    serial/8250: make PIO support optional
>
>   arch/mips/Kconfig                         |    7 -
>   arch/mips/alchemy/common/platform.c       |   50 +++
>   arch/mips/pmc-sierra/msp71xx/msp_serial.c |   32 ++-
>   arch/powerpc/kernel/legacy_serial.c       |   24 ++
>   drivers/tty/serial/8250.c                 |  472 +++--------------------------
>   drivers/tty/serial/8250.h                 |    8 +
>   drivers/tty/serial/8250_hub6.c            |   17 +
>   drivers/tty/serial/Kconfig                |   15 -
>   drivers/tty/serial/serial_core.c          |    4 -
>   drivers/tty/serial/sunsu.c                |   93 ------
>   include/linux/serial.h                    |    2 +-
>   include/linux/serial_core.h               |   10 +-
>   include/linux/serial_reg.h                |   51 ---
>   13 files changed, 171 insertions(+), 614 deletions(-)
>
> Cc: Ralf Baechle<ralf@linux-mips.org>
> Cc: linux-serial@vger.kernel.org
> Cc: Benjamin Herrenschmidt<benh@kernel.crashing.org>
>


FWIW, this was basically the intention when I added the I/O accessor 
functions.

If you like you can add:

Acked-by: David Daney <david.daney@cavium.com>