All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allison Henderson <achender@linux.vnet.ibm.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] XFS TESTS: Fix 252 Failure: Relax fiemap filter
Date: Mon, 27 Jun 2011 22:17:12 -0700	[thread overview]
Message-ID: <4E0963D8.5030002@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110628045903.GK32466@dastard>

On 06/27/2011 09:59 PM, Dave Chinner wrote:
> On Mon, Jun 27, 2011 at 09:27:25PM -0700, Allison Henderson wrote:
> I seriously dislike conditional parameter passing in shell scripts
> at the best of times, but for filter functions I really think it is
> the wrong thing to do. It significantly obfuscates the working of
> the function for no really good reason.
>
> Just write a new filter function, and factor out the common parts of
> them if the amount of code duplication is sufficient to make it
> desirable to do so.
>

Ok, it doesn't look like a lot of code, I can separate them into their
own functions.

>> +	md5sum $testfile | cut -d ' ' -f1
>
> Why cut out the file name? It's not like it changes at all....
>

Oh, it looked like there's a pid attached to the file name, so I thought 
I should remove that from the output

Allison Henderson



WARNING: multiple messages have this Message-ID (diff)
From: Allison Henderson <achender@linux.vnet.ibm.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH 1/3 v2] XFS TESTS: Fix 252 Failure: Relax fiemap filter
Date: Mon, 27 Jun 2011 22:17:12 -0700	[thread overview]
Message-ID: <4E0963D8.5030002@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110628045903.GK32466@dastard>

On 06/27/2011 09:59 PM, Dave Chinner wrote:
> On Mon, Jun 27, 2011 at 09:27:25PM -0700, Allison Henderson wrote:
> I seriously dislike conditional parameter passing in shell scripts
> at the best of times, but for filter functions I really think it is
> the wrong thing to do. It significantly obfuscates the working of
> the function for no really good reason.
>
> Just write a new filter function, and factor out the common parts of
> them if the amount of code duplication is sufficient to make it
> desirable to do so.
>

Ok, it doesn't look like a lot of code, I can separate them into their
own functions.

>> +	md5sum $testfile | cut -d ' ' -f1
>
> Why cut out the file name? It's not like it changes at all....
>

Oh, it looked like there's a pid attached to the file name, so I thought 
I should remove that from the output

Allison Henderson


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-06-28  5:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-28  4:27 [PATCH 0/3 v2] XFS TESTS: Fix 252 failure Allison Henderson
2011-06-28  4:27 ` Allison Henderson
2011-06-28  4:27 ` [PATCH 1/3 v2] XFS TESTS: Fix 252 Failure: Relax fiemap filter Allison Henderson
2011-06-28  4:27   ` Allison Henderson
2011-06-28  4:59   ` Dave Chinner
2011-06-28  4:59     ` Dave Chinner
2011-06-28  5:17     ` Allison Henderson [this message]
2011-06-28  5:17       ` Allison Henderson
2011-06-28  8:49       ` Dave Chinner
2011-06-28  4:27 ` [PATCH 2/3 v2] XFS TESTS: Fix 252 Failure: Update 252 Golden Output Allison Henderson
2011-06-28  4:27   ` Allison Henderson
2011-06-28  5:09   ` Dave Chinner
2011-06-28  5:09     ` Dave Chinner
2011-06-28  5:26     ` Allison Henderson
2011-06-28  5:26       ` Allison Henderson
2011-06-28 13:29       ` Eric Sandeen
2011-06-28 13:29         ` Eric Sandeen
2011-06-28 15:03         ` Allison Henderson
2011-06-28 15:03           ` Allison Henderson
2011-06-28  4:27 ` [PATCH 3/3 v2] XFS TESTS: Fix 252 Failure: Update 242 " Allison Henderson
2011-06-28  4:27   ` Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0963D8.5030002@linux.vnet.ibm.com \
    --to=achender@linux.vnet.ibm.com \
    --cc=david@fromorbit.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.