From: Jaehoon Chung <jh80.chung@samsung.com>
To: Philip Rakity <prakity@marvell.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [RFC] How working MMC_BUS_WIDTH_TEST??
Date: Wed, 29 Jun 2011 13:42:36 +0900 [thread overview]
Message-ID: <4E0AAD3C.5040201@samsung.com> (raw)
In-Reply-To: <A143AB12-AF84-4CD9-BA9C-97651D0ED29C@marvell.com>
Philip Rakity wrote:
> On Jun 28, 2011, at 3:54 AM, Jaehoon Chung wrote:
>
>> Hi..
>>
>> I found the MMC_CAP_BUS_WIDTH_TEST...
>> In mailing, I read the related patches..
>> but i didn't fully understand...
>>
>> /*
>> * If controller can't handle bus width test,
>> * compare ext_csd previously read in 1 bit mode
>> * against ext_csd at new bus width
>> */
>> if (!(host->caps & MMC_CAP_BUS_WIDTH_TEST))
>> err = mmc_compare_ext_csds(card,
>> ext_csd,
>> bus_width);
>> else
>> err = mmc_bus_test(card, bus_width);
>> if (!err)
>> break;
>>
>> And i tested suspend/resume..it's failed..
>> If i didn't set MMC_CAP_BUS_WIDTH_TEST, always return -EINVAL..
>> (using SDHCI controller, card is eMMC4.41)
>>
>> Didn't compare ext_csd's value..
>>
>> So i want to know how use MMC_CAP_BUS_WIDTH_TEST..
>
> I am using eMMC and code works fine so maybe there is issue in no ext_csd. You will need to
> add debug code to the compare_ext_csd and see what is not right and we can adjust the code.
> I am surprised that resume fails -- code will default to 1 bit data and it is NOT possible for this to
> be wrong. At the moment -- clueless to explain with more information.
>
> TheCMD14/ CMD19 is in JEDEC spec for bus width testing. Sends a pattern to the card and
> based on the returned values detects the bus width. Some controllers do NOT support this command.
> The just do not work. You need to figure this out by enabling the quirk. No other way to know.
When card is probing, i think that need to test bus-width.
If card is non-removable, unnecessary bus_width test during resuming.
Because already know that support n-bit bus-width..how about this?
>
> regards,
>
> Philip
>
>> Thanks,
>> Jaehoon Chung
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2011-06-29 4:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 10:54 [RFC] How working MMC_BUS_WIDTH_TEST?? Jaehoon Chung
2011-06-28 19:50 ` Philip Rakity
2011-06-29 4:42 ` Jaehoon Chung [this message]
2011-06-29 4:46 ` Philip Rakity
2011-06-30 2:12 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0AAD3C.5040201@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.