All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famcool@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Some uncertain about implementing stream optimized writing
Date: Wed, 29 Jun 2011 10:15:23 +0200	[thread overview]
Message-ID: <4E0ADF1B.7050107@redhat.com> (raw)
In-Reply-To: <BANLkTi=neLDthu+ZcN93EKKdfWDA0Q104w@mail.gmail.com>

Am 29.06.2011 06:47, schrieb Fam Zheng:
> Hi,
> 
> I have implemented reading for sparse optimized and come to implement
> writing. It is a little complicated and I am not sure what is the best
> approach. Could you give me some advice?
> 
> Here is the details: (pasted from http://warm.la/soc/?p=98)
> 
> Stream optimized VMDK image allocates minimized space for a compressed
> cluster, which means if there is high compress ratio, a cluster
> possibly only takes one physical sector in the file. It makes
> overwriting hard, especially when new data needs more sectors than
> previously allocated.
> 
> Attach the image to VMware and boot the VM to test this format, it
> seems that VMware wouldn’t do write to allocated clusters, but can
> allocate new cluster to save data.

I would have expected that they copy the data to a new cluster, like
qcow2 does.

Of course, it doesn't make a lot of sense to do COW if you can't free
the old space. Doing qcow2 style compression (which it seems to be from
your description) without having reference counts seems a bit stupid...

If you really can't write to already allocated clusters in VMware,
what's the use case for this? Have one read-only partition and
everything else free?

> Overwriting existing cluster requires measuring new data size and
> deciding whether in-place overwrite is OK, if not we must look for
> other free space. Metadata in image has no such information for sector
> allocation algorithm, so if we want to fully enable writing to stream
> optimized, sector allocation bitmap will be introduced into block
> state. This should significantly increase memory usage and somehow
> complicate the driver.

That would be 256k per GB. Sounds like it could become very large
indeed. Maybe better a free list approach and an image scan, like what
was considered for QED. Such a scan is unacceptable for a native format,
but maybe good enough for VMDK.

But how much is this format really used? Is it worth the trouble? If it
doesn't exist in practice, let's just leak the clusters. Whoever needs
more disk space should use qemu-img convert to compact it again.

Kevin

  parent reply	other threads:[~2011-06-29  8:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29  4:47 [Qemu-devel] Some uncertain about implementing stream optimized writing Fam Zheng
2011-06-29  5:47 ` Stefan Hajnoczi
2011-06-29  6:18   ` Fam Zheng
2011-06-29  8:12     ` Stefan Hajnoczi
2011-06-29  8:15 ` Kevin Wolf [this message]
2011-06-29  8:32   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0ADF1B.7050107@redhat.com \
    --to=kwolf@redhat.com \
    --cc=famcool@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.