All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Bauer <michael@m-bauer.org>
To: "Michal Malý" <madcatxster@gmail.com>
Cc: simon@mungewell.org, linux-input@vger.kernel.org, peter@slim-one.de
Subject: Re: [PATCH] Fix autocentering command in hid-lgff driver
Date: Wed, 29 Jun 2011 11:28:02 +0200	[thread overview]
Message-ID: <4E0AF022.8020609@m-bauer.org> (raw)
In-Reply-To: <4765696.45GeP0TYaU@qosmio-x300>

Am 27.06.2011 22:58, schrieb Michal Malý:
>> I think that we need to build a list/matrix and confirm that _all_ wheels
>> are OK with a single set of commands (autocenter for the FX excluded).
> I've tested your modded script and it worked fine with DFP. Peter who asked to be CC'ed too (I added him to CC) tried it
> out in G27 and reported that all was OK.
DFP, G25 and Momo Racing also worked fine on my side.

>> A resent patch (https://patchwork.kernel.org/patch/921052/) for the
>> WiiMote gives a good example how to implement '/sys/' files and we could
>> use these to control the wheel's modes, such as:
>>
>> /sys/bus/hid/drivers/lg4ff/<dev>/native - write 1 to switch to native,
>> read to get current state
>> /sys/bus/hid/drivers/lg4ff/<dev>/range - write angular range, read to get
>> current range
Yes, i also vote for something like this. Just keep in mind that we 
still need to find a reliable way to identify exactly the correct wheel, 
as they all register initially with the same VID/PID but need different 
commands for native mode and range.
This might be possible using the revision number - I am trying to get 
this implemented in ltwheelconf soon to have some more users test if it 
works.

>> Q. Do we need the ability to switch between split/combined pedals?
I am not sure on this - on the one hand i would love to provide all 
options to the user.
On the other hand i am not sure how this could be done. I do not think 
it is possible to change the report descriptor of a connected device on 
the fly without (not necessarily physically) reconnecting it?
And from my understanding the combined axes are just some kind of legacy 
stuff to support really old games which can not handle the separate axes.
So from my opinion we should at least initially just provide separate 
axes and don't try to implement complicated stuff to allow switching to 
combined mode.

> I guess I answered that above, I'd absolutely love to get this into the kernel. Using /sys sounds like the best way to me.
> There are two issues I can think of. First wheels actually simulate reconnect when they're switched to the native mode,
> so I guess we'd have to be careful and not cause any memory leaks and stuff. Second all Logitech wheels short of
> G25/27 need a replaced HID descriptor to get separate pedals working, so unless there's a reasonable way how to read
> the anonymous fields reported in the original descriptor, I say keep the pedals always separate for now.
I agree as stated above :-)

Best regards
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-06-29  9:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 20:42 [PATCH] Fix autocentering command in hid-lgff driver Michal Malý
2011-06-14 21:20 ` simon
2011-06-14 22:26   ` Michal Malý
2011-06-14 23:16     ` simon
2011-06-15  0:03       ` Michal Malý
     [not found]       ` <4429494.nOUqc25rPl@qosmio-x300>
2011-06-15 21:56         ` Michal Malý
     [not found] ` <1908821.jaYXT1Nn2e@qosmio-x300>
     [not found]   ` <da2b7e45ed001b587d49824944b802b8.squirrel@host171.canaca.com>
     [not found]     ` <201106262207.23918.michael@m-bauer.org>
2011-06-27 16:15       ` simon
2011-06-27 20:58         ` Michal Malý
2011-06-29  9:28           ` Michael Bauer [this message]
2011-06-29 15:23             ` Michael Bauer
2011-06-29 15:50             ` simon
2011-06-29 21:37               ` Michal Malý
2011-07-05 23:04               ` Michal Malý

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0AF022.8020609@m-bauer.org \
    --to=michael@m-bauer.org \
    --cc=linux-input@vger.kernel.org \
    --cc=madcatxster@gmail.com \
    --cc=peter@slim-one.de \
    --cc=simon@mungewell.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.