Hi Guillaume, On 06/29/2011 03:20 AM, Guillaume Zajac wrote: > Hi, > > Change log from v3: > - Fix some style issues > - update g_at_ppp_set_[acfc/pfc]_enabled() signatures > - update lcp functions setting acfc/pfc options > - we can now enable/disable ACFC or PFC to re-use the PPP object > with different parameters > > Guillaume Zajac (4): > GAtPPP: Add ACFC option support > GAtPPP: Add PFC option support > emulator: Activate ACFC and PFC options onto GAtPPP object > gsmdial: Activate ACFC and PFC options on GAtPPP object > > gatchat/gatppp.c | 155 +++++++++++++++++++++++++++++++++++++++++++++-------- > gatchat/gatppp.h | 3 + > gatchat/gsmdial.c | 3 + > gatchat/ppp.h | 12 ++++ > gatchat/ppp_lcp.c | 64 +++++++++++++++++++++- > src/emulator.c | 3 + > 6 files changed, 215 insertions(+), 25 deletions(-) > I went ahead and applied all four patches, thanks. I did do some minor refactoring afterwards to optimize the rx & tx flow. In my testing everything seems to be working fine, but please stress test it again to make sure. I also went ahead and marked the PFC & ACFC tasks as done. Regards, -Denis