From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbu7u-00089V-1i for qemu-devel@nongnu.org; Wed, 29 Jun 2011 08:44:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qbu7s-0007Jw-1W for qemu-devel@nongnu.org; Wed, 29 Jun 2011 08:44:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbu7r-0007Jo-Cw for qemu-devel@nongnu.org; Wed, 29 Jun 2011 08:44:15 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TCiES6004878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 08:44:14 -0400 Message-ID: <4E0B1E1B.4070803@redhat.com> Date: Wed, 29 Jun 2011 14:44:11 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1309348641-20061-1-git-send-email-alevy@redhat.com> <1309348641-20061-7-git-send-email-alevy@redhat.com> In-Reply-To: <1309348641-20061-7-git-send-email-alevy@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: yhalperi@redhat.com, qemu-devel@nongnu.org On 06/29/11 13:57, Alon Levy wrote: > --- > hw/qxl.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/qxl.h b/hw/qxl.h > index 7df594e..bf875a0 100644 > --- a/hw/qxl.h > +++ b/hw/qxl.h > @@ -89,7 +89,7 @@ typedef struct PCIQXLDevice { > > #define PANIC_ON(x) if ((x)) { \ > printf("%s: PANIC %s failed\n", __FUNCTION__, #x); \ > - exit(-1); \ > + abort(); \ > } Not urgent, but I think this should change. A bunch of the PANIC_ON checks are guest-triggerable. Long-term I want invalid requests from the guest just be ignored by default. Keeping an option to do something else is fine (log a message, abort, write out guest dump, whatever), I see that this can be quite useful for guest driver debugging. cheers, Gerd