From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbuQd-00053j-3h
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:03:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbuQa-0002tu-Qg
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:03:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2997)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QbuQa-0002tj-B3
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 09:03:36 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TD3ZF1020722
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 09:03:35 -0400
Message-ID: <4E0B22A4.1000802@redhat.com>
Date: Wed, 29 Jun 2011 15:03:32 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1309348641-20061-1-git-send-email-alevy@redhat.com>
	<1309348641-20061-11-git-send-email-alevy@redhat.com>
In-Reply-To: <1309348641-20061-11-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

   Hi,

> -        dprint(d, 1, "%s: unexpected port 0x%x in vga mode\n", __FUNCTION__, io_port);
> +        dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n",
> +            __FUNCTION__, io_port, io_port_to_string(io_port));

Is this worth it?  Should be a quite rare event ...

cheers,
   Gerd