diff for duplicates of <4E0B266D.30000@redhat.com> diff --git a/a/1.txt b/N1/1.txt index b99039d..496032a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,7 @@ On 06/29/2011 02:53 AM, Dave Chinner wrote: > On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: ->> This is a test to make sure seek_data/seek_hole is acting like it do= -es on ->> Solaris. It will check to see if the fs supports finding a hole or = -not and will +>> This is a test to make sure seek_data/seek_hole is acting like it does on +>> Solaris. It will check to see if the fs supports finding a hole or not and will >> adjust as necessary. > > So I just looked at this with an eye to validating an XFS @@ -34,15 +32,13 @@ not and will > writes close together in a file, and XFS is also known to > fill holes when doing sparse writes past EOF. > -> - only tests single block data extents =D1=95o doesn't cover +> - only tests single block data extents ѕo doesn't cover > corner cases like skipping over multiple fragmented data > extents to the next hole. > -Yeah I intentionally left out preallocated stuff because these are goin= -g=20 -to be implementation specific, so I was going to leave that for a later= -=20 +Yeah I intentionally left out preallocated stuff because these are going +to be implementation specific, so I was going to leave that for a later exercise when people actually start doing proper implementations. > Some more comments in line.... @@ -62,16 +58,15 @@ exercise when people actually start doing proper implementations. >> +_supported_fs generic >> +_supported_os Linux >> + ->> +testfile=3D$TEST_DIR/seek_test.$$ ->> +logfile=3D$TEST_DIR/seek_test.$$.log +>> +testfile=$TEST_DIR/seek_test.$$ +>> +logfile=$TEST_DIR/seek_test.$$.log > > The log file is usually named $seq.full, and doesn't get placed in > the filesystem being tested. It gets saved in the xfstests directory > along side $seq.out.bad for analysis whenteh test fails... > -I only want it to see if SEEK_HOLE fails so I can say it didn't run. I= -=20 +I only want it to see if SEEK_HOLE fails so I can say it didn't run. I followed the same example as the fiemap test that Eric wrote. >> +[ -x $here/src/seek-tester ] || _notrun "seek-tester not built" @@ -93,12 +88,11 @@ followed the same example as the fiemap test that Eric wrote. > to run the test manually and see what it is doing easily... > -Right, the problem with this test is it will run differently depending=20 -on the implementation. I agree, I really like the noisy output tests,=20 -but unfortunately if I run this test on ext4 where it currently treats=20 -the entire file as data, and then run it on btrfs where it is smarter=20 -and actually recognizes holes, we end up with two different outputs tha= -t=20 +Right, the problem with this test is it will run differently depending +on the implementation. I agree, I really like the noisy output tests, +but unfortunately if I run this test on ext4 where it currently treats +the entire file as data, and then run it on btrfs where it is smarter +and actually recognizes holes, we end up with two different outputs that are both correct. >> + @@ -109,7 +103,7 @@ are both correct. >> +rm -f $logfile >> +rm -f $testfile >> + ->> +status=3D0 ; exit +>> +status=0 ; exit >> diff --git a/255.out b/255.out >> new file mode 100644 >> index 0000000..7eefb82 @@ -139,7 +133,7 @@ are both correct. >> + char *test_desc; >> +}; >> + ->> +struct testrec seek_tests[] =3D { +>> +struct testrec seek_tests[] = { >> + { 1, test01, "Test basic support" }, >> + { 2, test02, "Test an empty file" }, >> + { 3, test03, "Test a full file" }, @@ -175,8 +169,12 @@ are both correct. > transitions between regions of those states as well, right? > -Yeah you are right, but again doing preallocated stuff is tricky, but I= -=20 +Yeah you are right, but again doing preallocated stuff is tricky, but I can expand it now if that's what we want. Thanks, Josef + +_______________________________________________ +xfs mailing list +xfs@oss.sgi.com +http://oss.sgi.com/mailman/listinfo/xfs diff --git a/a/content_digest b/N1/content_digest index 546c0d9..0af44af 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,18 +6,16 @@ "Date\0Wed, 29 Jun 2011 09:19:41 -0400\0" "To\0Dave Chinner <david@fromorbit.com>\0" "Cc\0linux-fsdevel@vger.kernel.org" + viro@zeniv.linux.org.uk linux-kernel@vger.kernel.org linux-btrfs@vger.kernel.org - xfs@oss.sgi.com - " viro@zeniv.linux.org.uk\0" + " xfs@oss.sgi.com\0" "\00:1\0" "b\0" "On 06/29/2011 02:53 AM, Dave Chinner wrote:\n" "> On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:\n" - ">> This is a test to make sure seek_data/seek_hole is acting like it do=\n" - "es on\n" - ">> Solaris. It will check to see if the fs supports finding a hole or =\n" - "not and will\n" + ">> This is a test to make sure seek_data/seek_hole is acting like it does on\n" + ">> Solaris. It will check to see if the fs supports finding a hole or not and will\n" ">> adjust as necessary.\n" ">\n" "> So I just looked at this with an eye to validating an XFS\n" @@ -48,15 +46,13 @@ "> \t writes close together in a file, and XFS is also known to\n" "> \t fill holes when doing sparse writes past EOF.\n" ">\n" - "> \t- only tests single block data extents =D1=95o doesn't cover\n" + "> \t- only tests single block data extents \321\225o doesn't cover\n" "> \t corner cases like skipping over multiple fragmented data\n" "> \t extents to the next hole.\n" ">\n" "\n" - "Yeah I intentionally left out preallocated stuff because these are goin=\n" - "g=20\n" - "to be implementation specific, so I was going to leave that for a later=\n" - "=20\n" + "Yeah I intentionally left out preallocated stuff because these are going \n" + "to be implementation specific, so I was going to leave that for a later \n" "exercise when people actually start doing proper implementations.\n" "\n" "> Some more comments in line....\n" @@ -76,16 +72,15 @@ ">> +_supported_fs generic\n" ">> +_supported_os Linux\n" ">> +\n" - ">> +testfile=3D$TEST_DIR/seek_test.$$\n" - ">> +logfile=3D$TEST_DIR/seek_test.$$.log\n" + ">> +testfile=$TEST_DIR/seek_test.$$\n" + ">> +logfile=$TEST_DIR/seek_test.$$.log\n" ">\n" "> The log file is usually named $seq.full, and doesn't get placed in\n" "> the filesystem being tested. It gets saved in the xfstests directory\n" "> along side $seq.out.bad for analysis whenteh test fails...\n" ">\n" "\n" - "I only want it to see if SEEK_HOLE fails so I can say it didn't run. I=\n" - "=20\n" + "I only want it to see if SEEK_HOLE fails so I can say it didn't run. I \n" "followed the same example as the fiemap test that Eric wrote.\n" "\n" ">> +[ -x $here/src/seek-tester ] || _notrun \"seek-tester not built\"\n" @@ -107,12 +102,11 @@ "> to run the test manually and see what it is doing easily...\n" ">\n" "\n" - "Right, the problem with this test is it will run differently depending=20\n" - "on the implementation. I agree, I really like the noisy output tests,=20\n" - "but unfortunately if I run this test on ext4 where it currently treats=20\n" - "the entire file as data, and then run it on btrfs where it is smarter=20\n" - "and actually recognizes holes, we end up with two different outputs tha=\n" - "t=20\n" + "Right, the problem with this test is it will run differently depending \n" + "on the implementation. I agree, I really like the noisy output tests, \n" + "but unfortunately if I run this test on ext4 where it currently treats \n" + "the entire file as data, and then run it on btrfs where it is smarter \n" + "and actually recognizes holes, we end up with two different outputs that \n" "are both correct.\n" "\n" ">> +\n" @@ -123,7 +117,7 @@ ">> +rm -f $logfile\n" ">> +rm -f $testfile\n" ">> +\n" - ">> +status=3D0 ; exit\n" + ">> +status=0 ; exit\n" ">> diff --git a/255.out b/255.out\n" ">> new file mode 100644\n" ">> index 0000000..7eefb82\n" @@ -153,7 +147,7 @@ ">> +\tchar\t*test_desc;\n" ">> +};\n" ">> +\n" - ">> +struct testrec seek_tests[] =3D {\n" + ">> +struct testrec seek_tests[] = {\n" ">> +\t{ 1, test01, \"Test basic support\" },\n" ">> +\t{ 2, test02, \"Test an empty file\" },\n" ">> +\t{ 3, test03, \"Test a full file\" },\n" @@ -189,10 +183,14 @@ "> transitions between regions of those states as well, right?\n" ">\n" "\n" - "Yeah you are right, but again doing preallocated stuff is tricky, but I=\n" - "=20\n" + "Yeah you are right, but again doing preallocated stuff is tricky, but I \n" "can expand it now if that's what we want. Thanks,\n" "\n" - Josef + "Josef\n" + "\n" + "_______________________________________________\n" + "xfs mailing list\n" + "xfs@oss.sgi.com\n" + http://oss.sgi.com/mailman/listinfo/xfs -6ebe8530b8dc3d07bcdd0c9b62de2dd8b84e36a2742a3229e60b55a6b5892185 +3dec108e9d827914cfaefec15fb84d7b8cb8ba06df01282efd2dbfa8f9eaa658
diff --git a/a/1.txt b/N2/1.txt index b99039d..572c51b 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,9 +1,7 @@ On 06/29/2011 02:53 AM, Dave Chinner wrote: > On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: ->> This is a test to make sure seek_data/seek_hole is acting like it do= -es on ->> Solaris. It will check to see if the fs supports finding a hole or = -not and will +>> This is a test to make sure seek_data/seek_hole is acting like it does on +>> Solaris. It will check to see if the fs supports finding a hole or not and will >> adjust as necessary. > > So I just looked at this with an eye to validating an XFS @@ -34,15 +32,13 @@ not and will > writes close together in a file, and XFS is also known to > fill holes when doing sparse writes past EOF. > -> - only tests single block data extents =D1=95o doesn't cover +> - only tests single block data extents ѕo doesn't cover > corner cases like skipping over multiple fragmented data > extents to the next hole. > -Yeah I intentionally left out preallocated stuff because these are goin= -g=20 -to be implementation specific, so I was going to leave that for a later= -=20 +Yeah I intentionally left out preallocated stuff because these are going +to be implementation specific, so I was going to leave that for a later exercise when people actually start doing proper implementations. > Some more comments in line.... @@ -62,16 +58,15 @@ exercise when people actually start doing proper implementations. >> +_supported_fs generic >> +_supported_os Linux >> + ->> +testfile=3D$TEST_DIR/seek_test.$$ ->> +logfile=3D$TEST_DIR/seek_test.$$.log +>> +testfile=$TEST_DIR/seek_test.$$ +>> +logfile=$TEST_DIR/seek_test.$$.log > > The log file is usually named $seq.full, and doesn't get placed in > the filesystem being tested. It gets saved in the xfstests directory > along side $seq.out.bad for analysis whenteh test fails... > -I only want it to see if SEEK_HOLE fails so I can say it didn't run. I= -=20 +I only want it to see if SEEK_HOLE fails so I can say it didn't run. I followed the same example as the fiemap test that Eric wrote. >> +[ -x $here/src/seek-tester ] || _notrun "seek-tester not built" @@ -93,12 +88,11 @@ followed the same example as the fiemap test that Eric wrote. > to run the test manually and see what it is doing easily... > -Right, the problem with this test is it will run differently depending=20 -on the implementation. I agree, I really like the noisy output tests,=20 -but unfortunately if I run this test on ext4 where it currently treats=20 -the entire file as data, and then run it on btrfs where it is smarter=20 -and actually recognizes holes, we end up with two different outputs tha= -t=20 +Right, the problem with this test is it will run differently depending +on the implementation. I agree, I really like the noisy output tests, +but unfortunately if I run this test on ext4 where it currently treats +the entire file as data, and then run it on btrfs where it is smarter +and actually recognizes holes, we end up with two different outputs that are both correct. >> + @@ -109,7 +103,7 @@ are both correct. >> +rm -f $logfile >> +rm -f $testfile >> + ->> +status=3D0 ; exit +>> +status=0 ; exit >> diff --git a/255.out b/255.out >> new file mode 100644 >> index 0000000..7eefb82 @@ -139,7 +133,7 @@ are both correct. >> + char *test_desc; >> +}; >> + ->> +struct testrec seek_tests[] =3D { +>> +struct testrec seek_tests[] = { >> + { 1, test01, "Test basic support" }, >> + { 2, test02, "Test an empty file" }, >> + { 3, test03, "Test a full file" }, @@ -175,8 +169,7 @@ are both correct. > transitions between regions of those states as well, right? > -Yeah you are right, but again doing preallocated stuff is tricky, but I= -=20 +Yeah you are right, but again doing preallocated stuff is tricky, but I can expand it now if that's what we want. Thanks, Josef diff --git a/a/content_digest b/N2/content_digest index 546c0d9..bf8797b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -14,10 +14,8 @@ "b\0" "On 06/29/2011 02:53 AM, Dave Chinner wrote:\n" "> On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote:\n" - ">> This is a test to make sure seek_data/seek_hole is acting like it do=\n" - "es on\n" - ">> Solaris. It will check to see if the fs supports finding a hole or =\n" - "not and will\n" + ">> This is a test to make sure seek_data/seek_hole is acting like it does on\n" + ">> Solaris. It will check to see if the fs supports finding a hole or not and will\n" ">> adjust as necessary.\n" ">\n" "> So I just looked at this with an eye to validating an XFS\n" @@ -48,15 +46,13 @@ "> \t writes close together in a file, and XFS is also known to\n" "> \t fill holes when doing sparse writes past EOF.\n" ">\n" - "> \t- only tests single block data extents =D1=95o doesn't cover\n" + "> \t- only tests single block data extents \321\225o doesn't cover\n" "> \t corner cases like skipping over multiple fragmented data\n" "> \t extents to the next hole.\n" ">\n" "\n" - "Yeah I intentionally left out preallocated stuff because these are goin=\n" - "g=20\n" - "to be implementation specific, so I was going to leave that for a later=\n" - "=20\n" + "Yeah I intentionally left out preallocated stuff because these are going \n" + "to be implementation specific, so I was going to leave that for a later \n" "exercise when people actually start doing proper implementations.\n" "\n" "> Some more comments in line....\n" @@ -76,16 +72,15 @@ ">> +_supported_fs generic\n" ">> +_supported_os Linux\n" ">> +\n" - ">> +testfile=3D$TEST_DIR/seek_test.$$\n" - ">> +logfile=3D$TEST_DIR/seek_test.$$.log\n" + ">> +testfile=$TEST_DIR/seek_test.$$\n" + ">> +logfile=$TEST_DIR/seek_test.$$.log\n" ">\n" "> The log file is usually named $seq.full, and doesn't get placed in\n" "> the filesystem being tested. It gets saved in the xfstests directory\n" "> along side $seq.out.bad for analysis whenteh test fails...\n" ">\n" "\n" - "I only want it to see if SEEK_HOLE fails so I can say it didn't run. I=\n" - "=20\n" + "I only want it to see if SEEK_HOLE fails so I can say it didn't run. I \n" "followed the same example as the fiemap test that Eric wrote.\n" "\n" ">> +[ -x $here/src/seek-tester ] || _notrun \"seek-tester not built\"\n" @@ -107,12 +102,11 @@ "> to run the test manually and see what it is doing easily...\n" ">\n" "\n" - "Right, the problem with this test is it will run differently depending=20\n" - "on the implementation. I agree, I really like the noisy output tests,=20\n" - "but unfortunately if I run this test on ext4 where it currently treats=20\n" - "the entire file as data, and then run it on btrfs where it is smarter=20\n" - "and actually recognizes holes, we end up with two different outputs tha=\n" - "t=20\n" + "Right, the problem with this test is it will run differently depending \n" + "on the implementation. I agree, I really like the noisy output tests, \n" + "but unfortunately if I run this test on ext4 where it currently treats \n" + "the entire file as data, and then run it on btrfs where it is smarter \n" + "and actually recognizes holes, we end up with two different outputs that \n" "are both correct.\n" "\n" ">> +\n" @@ -123,7 +117,7 @@ ">> +rm -f $logfile\n" ">> +rm -f $testfile\n" ">> +\n" - ">> +status=3D0 ; exit\n" + ">> +status=0 ; exit\n" ">> diff --git a/255.out b/255.out\n" ">> new file mode 100644\n" ">> index 0000000..7eefb82\n" @@ -153,7 +147,7 @@ ">> +\tchar\t*test_desc;\n" ">> +};\n" ">> +\n" - ">> +struct testrec seek_tests[] =3D {\n" + ">> +struct testrec seek_tests[] = {\n" ">> +\t{ 1, test01, \"Test basic support\" },\n" ">> +\t{ 2, test02, \"Test an empty file\" },\n" ">> +\t{ 3, test03, \"Test a full file\" },\n" @@ -189,10 +183,9 @@ "> transitions between regions of those states as well, right?\n" ">\n" "\n" - "Yeah you are right, but again doing preallocated stuff is tricky, but I=\n" - "=20\n" + "Yeah you are right, but again doing preallocated stuff is tricky, but I \n" "can expand it now if that's what we want. Thanks,\n" "\n" Josef -6ebe8530b8dc3d07bcdd0c9b62de2dd8b84e36a2742a3229e60b55a6b5892185 +cfd959d71dd2e705b690cc0b16c02aab904aba53894fbf9ff62ae96447aa6f85
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.