From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: [RFC v2 2/2] e100: Support RXFCS feature flag. Date: Wed, 29 Jun 2011 07:35:42 -0700 Message-ID: <4E0B383E.8020807@candelatech.com> References: <1308942371-12748-1-git-send-email-greearb@candelatech.com> <1308942371-12748-3-git-send-email-greearb@candelatech.com> <4E0B3510.2080202@candelatech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org To: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= Return-path: Received: from mail.candelatech.com ([208.74.158.172]:39551 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755449Ab1F2Ofp (ORCPT ); Wed, 29 Jun 2011 10:35:45 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 06/29/2011 07:33 AM, Micha=B3 Miros=B3aw wrote: > W dniu 29 czerwca 2011 16:22 u=BFytkownik Ben Greear > napisa=B3: >> On 06/29/2011 04:37 AM, Micha=B3 Miros=B3aw wrote: >>> 2011/6/24: >>>> From: Ben Greear >>>> >>>> This allows e100 to be configured to append the >>>> Ethernet FCS to the skb. >>>> >>>> Useful for sniffing networks. >>>> >>>> Signed-off-by: Ben Greear >>>> --- >>>> :100644 100644 c1352c6... 761f6f5... M drivers/net/e100.c >>>> drivers/net/e100.c | 15 ++++++++++++--- >>>> 1 files changed, 12 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/net/e100.c b/drivers/net/e100.c >>>> index c1352c6..761f6f5 100644 >>>> --- a/drivers/net/e100.c >>>> +++ b/drivers/net/e100.c >>>> @@ -1089,6 +1089,7 @@ static void e100_configure(struct nic *nic, = struct >>>> cb *cb, struct sk_buff *skb) >>>> { >>>> struct config *config =3D&cb->u.config; >>>> u8 *c =3D (u8 *)config; >>>> + struct net_device *netdev =3D nic->netdev; >>>> >>>> cb->command =3D cpu_to_le16(cb_config); >>>> >>>> @@ -1132,6 +1133,9 @@ static void e100_configure(struct nic *nic, = struct >>>> cb *cb, struct sk_buff *skb) >>>> config->promiscuous_mode =3D 0x1; /* 1=3Do= n, 0=3Doff */ >>>> } >>>> >>>> + if (netdev->wanted_features& NETIF_F_RXFCS) >>>> + config->rx_crc_transfer =3D 0x1; /* 1=3Dsave, 0=3D= discard */ >>>> + >>> You should check netdev->features here. >> I thought 'features' was what the NIC could support, and wanted_feat= ures >> was what the NIC was currently configured to support? I don't want >> to rx the CRC all the time, just when users enable it... > > hw_features is what device could support, and features is what device > has currently turned on. Ok, thanks for that correction. What does wanted_features mean, then? Thanks, Ben > > Best Regards, > Micha=B3 Miros=B3aw --=20 Ben Greear Candela Technologies Inc http://www.candelatech.com