From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbx4T-0001lg-Mr for qemu-devel@nongnu.org; Wed, 29 Jun 2011 11:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qbx4S-0002Bb-AI for qemu-devel@nongnu.org; Wed, 29 Jun 2011 11:52:57 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:44407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qbx4R-0002BN-RH for qemu-devel@nongnu.org; Wed, 29 Jun 2011 11:52:56 -0400 Received: by wyf28 with SMTP id 28so1060983wyf.4 for ; Wed, 29 Jun 2011 08:52:54 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E0B4A53.6000903@redhat.com> Date: Wed, 29 Jun 2011 17:52:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20110628153516.GA8596@redhat.com> <823452D2-B620-40F2-8423-917947A0F3A3@suse.de> <20110629131124.GA18283@redhat.com> <5E0F3960-6FEB-4F97-8590-DC7AEB15BDCE@suse.de> In-Reply-To: <5E0F3960-6FEB-4F97-8590-DC7AEB15BDCE@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add compat eventfd header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Stefan Hajnoczi , "Michael S.Tsirkin" , qemu-devel@nongnu.org, Blue Swirl , jan.kiszka@web.de, Aurelien Jarno On 06/29/2011 03:22 PM, Alexander Graf wrote: > Well, you need to make sure that it only gets included on Linux > systems and if there's ever some more compatibility wrapping around > the syscall (unlikely, but you never know), this could potentially > break. > > Also, who defines SYS_eventfd? What if you're trying to build this > code on SLES10 for example, which does not have the syscall and thus > doesn't have it defined? Would compilation simply break? No, he patched configure to use the compat header too, so detection would fail at configure time and eventfd would not be used. Paolo