Re: [PATCH v3 1/6] btrfs: add READAHEAD extent buffer flag

[Josef Bacik <josef@redhat.com>]

On 06/29/2011 12:32 PM, Arne Jansen wrote:
> Add a READAHEAD extent buffer flag.
> Add a function to trigger a read with this flag set.
>=20
> Changes v2:
>  - use extent buffer flags instead of extent state flags
>=20
> Signed-off-by: Arne Jansen <sensille@gmx.net>
> ---
>  fs/btrfs/disk-io.c   |   32 ++++++++++++++++++++++++++++++++
>  fs/btrfs/disk-io.h   |    2 ++
>  fs/btrfs/extent_io.h |    1 +
>  3 files changed, 35 insertions(+), 0 deletions(-)
>=20
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 0339cc0..0195172 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -945,6 +945,38 @@ int readahead_tree_block(struct btrfs_root *root=
, u64 bytenr, u32 blocksize,
>  	return ret;
>  }
> =20
> +int reada_tree_block_flagged(struct btrfs_root *root, u64 bytenr, u3=
2 blocksize,
> +			 int mirror_num, struct extent_buffer **eb)
> +{
> +	struct extent_buffer *buf =3D NULL;
> +	struct inode *btree_inode =3D root->fs_info->btree_inode;
> +	struct extent_io_tree *io_tree =3D &BTRFS_I(btree_inode)->io_tree;
> +	int ret;
> +
> +	buf =3D btrfs_find_create_tree_block(root, bytenr, blocksize);
> +	if (!buf)
> +		return 0;
> +
> +	set_bit(EXTENT_BUFFER_READAHEAD, &buf->bflags);
> +
> +	ret =3D read_extent_buffer_pages(io_tree, buf, 0, 0, 1, btree_get_e=
xtent,
> +				 mirror_num);

This patch doesn't compile for me, it says there are too many arguments=
 here.

[root@destiny btrfs-work]# make M=3Dfs/btrfs
  CC [M]  fs/btrfs/disk-io.o
fs/btrfs/disk-io.c: In function =91reada_tree_block_flagged=92:
fs/btrfs/disk-io.c:963:6: warning: passing argument 5 of =91read_extent=
_buffer_pages=92 makes pointer from integer without a cast [enabled by =
default]
fs/btrfs/extent_io.h:244:5: note: expected =91struct extent_map * (*)(s=
truct inode *, struct page *, size_t,  u64,  u64,  int)=92 but argument=
 is of type =91int=92
fs/btrfs/disk-io.c:963:6: warning: passing argument 6 of =91read_extent=
_buffer_pages=92 makes integer from pointer without a cast [enabled by =
default]
fs/btrfs/extent_io.h:244:5: note: expected =91int=92 but argument is of=
 type =91struct extent_map * (*)(struct inode *, struct page *, size_t,=
  u64,  u64,  int)=92
fs/btrfs/disk-io.c:963:6: error: too many arguments to function =91read=
_extent_buffer_pages=92
fs/btrfs/extent_io.h:244:5: note: declared here
make[1]: *** [fs/btrfs/disk-io.o] Error 1
make: *** [_module_fs/btrfs] Error 2

Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html