From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH V1] led: pm8xxx: Add pm8xxx leds driver Date: Wed, 29 Jun 2011 11:28:56 -0700 Message-ID: <4E0B6EE8.9070202@codeaurora.org> References: <1308739783-4643-1-git-send-email-aghayal@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:25284 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756837Ab1F2S25 (ORCPT ); Wed, 29 Jun 2011 14:28:57 -0400 In-Reply-To: <1308739783-4643-1-git-send-email-aghayal@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Anirudh Ghayal Cc: Lars-Peter Clausen , Richard Purdie , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Trilok Soni On 06/22/2011 03:49 AM, Anirudh Ghayal wrote: > + > +/** > + * struct pm8xxx_led_data - internal led data structure > + * @led_classdev - led class device > + * @id - led index > + * @led_brightness - led brightness levels > + * @work - workqueue for led > + * @lock - to protect the transactions > + * @reg - cached value of led register > + */ This isn't kerneldoc notation. > +fail_id_check: > + if (i > 0) { > + for (i = i - 1; i >= 0; i--) { > + int index = pdata->leds[i].flags; > + mutex_destroy(&led[index].lock); > + led_classdev_unregister(&led[index].cdev); > + } > + } if (i > 0) is redundant here. > +/** > + * enum pm8xxx_leds - PMIC8XXX supported led ids > + * @PM8XXX_ID_LED_KB_LIGHT - keyboard backlight led > + * @PM8XXX_ID_LED_0 - First low current led > + * @PM8XXX_ID_LED_1 - Second low current led > + * @PM8XXX_ID_LED_2 - Third low current led > + * @PM8XXX_ID_FLASH_LED_0 - First flash led > + * @PM8XXX_ID_FLASH_LED_0 - Second flash led > + */ > + This isn't kerneldoc notation. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.