From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: Incoming patch HS2330 detection, plugins/udev.c
Date: Thu, 30 Jun 2011 01:47:24 -0500 [thread overview]
Message-ID: <4E0C1BFC.8060904@gmail.com> (raw)
In-Reply-To: <1309437084-3062-1-git-send-email-ofonoconn@encambio.com>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
Hi Michael,
On 06/30/2011 07:31 AM, Michael Schloh von Bennewitz wrote:
> This patch is assembled according to discussions on #ofono
> irc.freenode.net and mailing list thread 'Problem detecting/using wwan0
> modem' in June 2011, after comprehensive guidance from Denis KENZIOR.
>
> Denis had already modified plugins/udev.c in git commit
> 6a2847f7aba5d84b06940ee29300d4b6fd31d682 to correct detection of
> OEM Ericsson F3607gw modems relabeled by HP and sold as HS2330.
> Because some (or all?) HS2330 modems contain flawed text identifiers
> containing strange (probably erroneous) binary sequences in place of
> the ASCII space '\x20' character, the previous commit is incomplete.
> The following logic detects the modem properly, by comparing binary
> data as well as ASCII text values.
>
Patch has been applied with a slightly reformatted commit message.
Regards,
-Denis
next prev parent reply other threads:[~2011-06-30 6:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 15:45 Problem detecting/using wwan0 modem ofonoconn
2011-06-27 14:12 ` Denis Kenzior
2011-06-27 17:25 ` ofonoconn
2011-06-27 15:53 ` Denis Kenzior
2011-06-27 18:43 ` ofonoconn
2011-06-27 16:46 ` Denis Kenzior
2011-06-27 19:04 ` ofonoconn
2011-06-27 17:21 ` Denis Kenzior
2011-06-27 19:32 ` Michael Schloh von Bennewitz
2011-06-28 17:05 ` ofonoconn
2011-06-28 20:07 ` Michael Schloh von Bennewitz
2011-06-30 12:31 ` Incoming patch HS2330 detection, plugins/udev.c Michael Schloh von Bennewitz
2011-06-30 6:47 ` Denis Kenzior [this message]
2011-06-30 19:46 ` Michael Schloh von Bennewitz
2011-06-30 20:20 ` Marcel Holtmann
2011-07-02 19:08 ` Michael
2011-07-20 12:55 ` Nicolas Paccou
2011-06-27 17:38 ` Problem detecting/using wwan0 modem ofonoconn
2011-06-27 15:50 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C1BFC.8060904@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.