From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcClm-0004bn-7d for qemu-devel@nongnu.org; Thu, 30 Jun 2011 04:38:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcClk-0006I0-51 for qemu-devel@nongnu.org; Thu, 30 Jun 2011 04:38:41 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:50181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcClj-0006Hq-LX for qemu-devel@nongnu.org; Thu, 30 Jun 2011 04:38:39 -0400 Message-ID: <4E0C360B.5060406@adacore.com> Date: Thu, 30 Jun 2011 10:38:35 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1309178511-20027-1-git-send-email-chouteau@adacore.com> <4E08925F.3030605@adacore.com> <4E08ABF4.1010206@adacore.com> <4E099A15.4050004@adacore.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Make SLIRP Ethernet packets size to 64 bytes minimuma List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org On 28/06/2011 15:15, Stefan Hajnoczi wrote: > On Tue, Jun 28, 2011 at 10:08 AM, Fabien Chouteau wrote: >> On 28/06/2011 10:34, Stefan Hajnoczi wrote: >>> This patch doesn't hurt but we'd be just as well off without it. >>> >>> Did you do this to fix a bug? If so, then something else in QEMU >>> needs to be fixed, not slirp. >> >> When Qemu generates bad Ethernet frames, I think it's a bug. >> >> And again, this is the extension of a previous patch. If this patch is not >> valid then we should revert the first, it's also a question of consistency. > > IMO the previous patch is not necessary either. > > Since there is no net subsystem maintainer who can help decide which > way to go, I'm going to back off from this issue. Please go ahead. > OK thanks. Any other comments? -- Fabien Chouteau