Re: [patch 1/5] i8253: Create common clockevent implementation

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2011/06/26 5:03), Stijn Devriendt wrote:
>> +/*
>> + * Initialize the conversion factor and the min/max deltas of the clock event
>> + * structure and register the clock event source with the framework.
>> + */
>> +void __init clockevent_i8253_init(bool oneshot)
>> +{
>> +       if (oneshot)
>> +               i8253_clockevent.features |= CLOCK_EVT_FEAT_ONESHOT;
>> +       /*
>> +        * Start pit with the boot cpu mask. x86 might make it global
>> +        * when it is used as broadcast device later.
>> +        */
>> +       i8253_clockevent.cpumask = cpumask_of(smp_processor_id());
>> +
>> +       clockevents_config_and_register(&i8253_clockevent, PIT_TICK_RATE,
>> +                                       0xF, 0x7FFF);
>> +}
>> +#endif
>>
> Both this function and the i8253_clockevent declaration seem to be missing
> from include/linux/i8253.h causing compile failures for at least x86.
> 
> I was just trying to compile tip of
> git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched-devel.git

I've met same problem on latest tip tree.

> Should be fixed by applying the following patch.

We still need to expose clocksource_i8253_init() too
for CONFIG_X86_64=n.
So, could you update your patch (and send it as a patch mail)?

Thank you,

> 
> commit 0c24072a8d580acd5b4fc57009b72b217c0f23d9
> Author: Stijn Devriendt <HIGHGuY@gmail.com>
> Date:   Sat Jun 25 22:04:53 2011 +0200
> 
>     Fix missing declarations of i8253.
> 
>     Signed-off-by: Stijn Devriendt <HIGHGuY@gmail.com>
> 
> diff --git a/include/linux/i8253.h b/include/linux/i8253.h
> index 0770fc5..e6c032f 100644
> --- a/include/linux/i8253.h
> +++ b/include/linux/i8253.h
> @@ -22,6 +22,10 @@
> 
>  extern raw_spinlock_t i8253_lock;
> 
> +extern struct clock_event_device i8253_clockevent;
> +
>  extern void setup_pit_timer(void);
> 
> +extern void clockevent_i8253_init(bool oneshot);
> +
>  #endif /* __LINUX_I8253_H */


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com